Skip to content

Comments

Change: move timezone init out of print_report_xml_start#2662

Merged
greenbonebot merged 3 commits intomainfrom
smaller-print-report-5
Dec 4, 2025
Merged

Change: move timezone init out of print_report_xml_start#2662
greenbonebot merged 3 commits intomainfrom
smaller-print-report-5

Conversation

@mattmundell
Copy link
Contributor

What

Use a separate function to do the timezone info init for print_report_xml_start.

Why

To make print_report_xml_start easier to maintain.

References

Follows #2653.

Testing

I got a single report with the PR, then got the same report on the main branch. I made sure they were the same. I did that with two timezones just to be sure (using the timezone term in the filter).

o m m '<get_reports report_id="92a09ffd-a5bd-464b-9f2c-54b78ec5ebcf" details="1" filter="timezone=Pacific/Auckland rows=3 apply_overrides=1 min_qod=60"/>' > /tmp/r-auk-main
o m m '<get_reports report_id="92a09ffd-a5bd-464b-9f2c-54b78ec5ebcf" details="1" filter="timezone=Europe/Berlin rows=3 apply_overrides=1 min_qod=60"/>' > /tmp/r-ber-main
diff /tmp/r-auk /tmp/r-auk-main
diff /tmp/r-ber /tmp/r-ber-main

@mattmundell mattmundell requested review from a team as code owners December 1, 2025 16:14
@greenbonebot greenbonebot enabled auto-merge (rebase) December 1, 2025 16:14
@greenbonebot greenbonebot merged commit 8b5dee3 into main Dec 4, 2025
29 of 30 checks passed
@greenbonebot greenbonebot deleted the smaller-print-report-5 branch December 4, 2025 15:36
@mattmundell
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants