Change: move timezone init out of print_report_xml_start#2662
Merged
greenbonebot merged 3 commits intomainfrom Dec 4, 2025
Merged
Change: move timezone init out of print_report_xml_start#2662greenbonebot merged 3 commits intomainfrom
greenbonebot merged 3 commits intomainfrom
Conversation
ozgen
reviewed
Dec 4, 2025
ozgen
approved these changes
Dec 4, 2025
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use a separate function to do the timezone info init for
print_report_xml_start.Why
To make
print_report_xml_starteasier to maintain.References
Follows #2653.
Testing
I got a single report with the PR, then got the same report on the
mainbranch. I made sure they were the same. I did that with two timezones just to be sure (using thetimezoneterm in the filter).