Change: Refactor GMP errors for import task and extend filter_clause#2666
Merged
greenbonebot merged 8 commits intomainfrom Dec 4, 2025
Merged
Conversation
mattmundell
requested changes
Dec 4, 2025
ozgen
force-pushed
the
fix-gmp-errors-for-import-task-filter-clause-agent-oci
branch
from
9e72f91 to
20ca230
Compare
mattmundell
requested changes
Dec 4, 2025
Contributor
mattmundell
left a comment
mattmundell
left a comment
There was a problem hiding this comment.
I see another one in the return doc at manage_sql.c:9943.
ozgen
force-pushed
the
fix-gmp-errors-for-import-task-filter-clause-agent-oci
branch
from
52321f4 to
1495314
Compare
Co-authored-by: Matt Mundell <32057441+mattmundell@users.noreply.github.com>
ozgen
force-pushed
the
fix-gmp-errors-for-import-task-filter-clause-agent-oci
branch
2 times, most recently
from
d1b7a5e to
79a82c4
Compare
Co-authored-by: Matt Mundell <32057441+mattmundell@users.noreply.github.com>
ozgen
force-pushed
the
fix-gmp-errors-for-import-task-filter-clause-agent-oci
branch
from
79a82c4 to
d68abcf
Compare
mattmundell
requested changes
Dec 4, 2025
Contributor
mattmundell
left a comment
mattmundell
left a comment
There was a problem hiding this comment.
Last couple I can see.
Co-authored-by: Matt Mundell <32057441+mattmundell@users.noreply.github.com>
Co-authored-by: Matt Mundell <32057441+mattmundell@users.noreply.github.com>
…ilter-clause-agent-oci' into fix-gmp-errors-for-import-task-filter-clause-agent-oci
mattmundell
approved these changes
Dec 4, 2025
greenbonebot
deleted the
fix-gmp-errors-for-import-task-filter-clause-agent-oci
branch
Contributor
|
@ozgen if you have a gap at any point, I'd like a review of /pull/2662. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
agent_groupandoci_image_targetwere not fully supported infilter_clause, which led to incorrect or incomplete filtering.References
GEA-1406