Change: start moving filter section out of manage_sql.c#2563
Merged
greenbonebot merged 2 commits intomainfrom Sep 29, 2025
Merged
Change: start moving filter section out of manage_sql.c#2563greenbonebot merged 2 commits intomainfrom
greenbonebot merged 2 commits intomainfrom
Conversation
7f0afdb to
dc2da10
Compare
bjoernricks
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move first four functions from
manage_sql.cto dedicated files.Why
Better organisation. Smaller
manage_sql.c.References
Similar to #2523 for Assets.
Testing
o m m '<get_targets filter="rows=5"/>'o m m '<get_targets filter="first=2 rows=2"/>'o m m '<get_reports report_id="ce802cc5-d8ed-4f7f-b303-96cb0eed08da" details="1" filter="rows=3" report_filter="rows=4"/>'
o m m '<get_targets filter_replace="xxx" filter="rows=1 xxx=33"/>'
o m m '<get_targets filter="rows=1 xxx=33"/>'