Skip to content

Comments

Change: start moving filter section out of manage_sql.c#2563

Merged
greenbonebot merged 2 commits intomainfrom
filter-files-1
Sep 29, 2025
Merged

Change: start moving filter section out of manage_sql.c#2563
greenbonebot merged 2 commits intomainfrom
filter-files-1

Conversation

@mattmundell
Copy link
Contributor

What

Move first four functions from manage_sql.c to dedicated files.

Why

Better organisation. Smaller manage_sql.c.

References

Similar to #2523 for Assets.

Testing

  • manage_filter_controls check start,max
    o m m '<get_targets filter="rows=5"/>'
    o m m '<get_targets filter="first=2 rows=2"/>'
  • manage_report_filter_controls check PORTS/COUNT, and manage_clean_filter check that min_qod added to FILTER/TERM
    o m m '<get_reports report_id="ce802cc5-d8ed-4f7f-b303-96cb0eed08da" details="1" filter="rows=3" report_filter="rows=4"/>'
  • manage_clean_filter_remove check term reordering to confirm that it ran
    o m m '<get_targets filter_replace="xxx" filter="rows=1 xxx=33"/>'
    o m m '<get_targets filter="rows=1 xxx=33"/>'

@mattmundell mattmundell requested review from a team as code owners September 24, 2025 11:12
@greenbonebot greenbonebot enabled auto-merge (rebase) September 24, 2025 11:12
@greenbonebot greenbonebot merged commit de6b569 into main Sep 29, 2025
23 of 24 checks passed
@greenbonebot greenbonebot deleted the filter-files-1 branch September 29, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants