Remove URI.escape and add ruby 3 rexml dependency#55
Open
fusion2004 wants to merge 2 commits intogreatseth:masterfrom
Open
Remove URI.escape and add ruby 3 rexml dependency#55fusion2004 wants to merge 2 commits intogreatseth:masterfrom
fusion2004 wants to merge 2 commits intogreatseth:masterfrom
Conversation
…ded in the standard distribution
Collaborator
|
Hey @fusion2004, I'm unbelievably overwhelmed with some other project. I love what you're trying to do here and wanted to get around to this sooner or later. I should be able to get to the review soon, but can't right now. Thanks for your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I'm not sure this is how you wanted to handle this, but I noted the TODO in the readme about this, and wanted to get this gem working on ruby 3.0.
I can't seem to even create a URI object with unescaped components, and there didn't seem to be a test for it that broke from this change.
Here are my failed attempts
Additionally, it seems that the
rexmldependency must be declared explicitly to work with ruby 3.Let me know if you want me to take a different direction with this!