Skip to content

Remove URI.escape and add ruby 3 rexml dependency #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fusion2004 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove URI.escape and add ruby 3 rexml dependency #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e80d934
don't URI.escape the URI, as that method has been removed
fusion2004 May 25, 2021
ad43652
add rexml as a dependency, since as of ruby 3.0 it is no longer inclu…
fusion2004 May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/mediainfo.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def self.from_uri(input)
http.use_ssl = true if input.is_a? URI::HTTPS # For https support
http_request = http.request(request)
raise RemoteUrlError, "HTTP call to #{input} is not working : #{http_request.value}" unless http_request.is_a?(Net::HTTPOK)
MediaInfo::Tracks.new(MediaInfo.run(URI.escape(input.to_s)))
MediaInfo::Tracks.new(MediaInfo.run(input.to_s))
end
end

Expand Down
3 changes: 2 additions & 1 deletion mediainfo.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ Gem::Specification.new do |s|
f.match(%r{^(test|spec|features)/})
end

# Since Ruby 1.8, REXML is included in the standard Ruby distribution.
s.add_dependency 'rexml'

s.add_development_dependency 'bundler', '~> 2'
s.add_development_dependency 'rake', '~> 12.3'
s.add_development_dependency 'rspec', '~> 3.0'
Expand Down