Optimize batch addition

.github/workflows/backend-tests.yml

@@ -58,6 +58,12 @@ jobs:
           command: fmt
           args: --manifest-path kzg-bench/Cargo.toml -- --check
 
+      - name: "kzg tests"
+        uses: actions-rs/cargo@v1
+        with:
+          command: test
+          args: --manifest-path kzg/Cargo.toml --no-fail-fast --release
+
   backend_ci:
     runs-on: ${{ matrix.os }}
     strategy:

arkworks3/Cargo.toml

@@ -57,6 +57,10 @@ diskcache = [
     "kzg/diskcache"
 ]
 
+[[bench]]
+name = "batch_addition"
+harness = false
+
 [[bench]]
 name = "fft"
 harness = false

arkworks3/benches/batch_addition.rs

@@ -0,0 +1,15 @@
+use criterion::{criterion_group, criterion_main, Criterion};
+use kzg_bench::benches::batch_addition::bench_batch_addition;
+use rust_kzg_arkworks3::eip_7594::ArkBackend;
+
+fn bench_batch_addition_(c: &mut Criterion) {
+    bench_batch_addition::<ArkBackend>(c)
+}
+
+criterion_group! {
+    name = benches;
+    config = Criterion::default();
+    targets = bench_batch_addition_
+}
+
+criterion_main!(benches);

arkworks3/tests/batch_addition.rs

@@ -0,0 +1,7 @@
+#[cfg(test)]
+mod tests {
+    use kzg_bench::instantiate_batch_addition_tests;
+    use rust_kzg_arkworks3::eip_7594::ArkBackend;
+
+    instantiate_batch_addition_tests!(ArkBackend);
+}

arkworks4/Cargo.toml

@@ -56,6 +56,10 @@ diskcache = [
     "kzg/diskcache"
 ]
 
+[[bench]]
+name = "batch_addition"
+harness = false
+
 [[bench]]
 name = "fft"
 harness = false

arkworks4/benches/batch_addition.rs

@@ -0,0 +1,15 @@
+use criterion::{criterion_group, criterion_main, Criterion};
+use kzg_bench::benches::batch_addition::bench_batch_addition;
+use rust_kzg_arkworks4::eip_7594::ArkBackend;
+
+fn bench_batch_addition_(c: &mut Criterion) {
+    bench_batch_addition::<ArkBackend>(c)
+}
+
+criterion_group! {
+    name = benches;
+    config = Criterion::default();
+    targets = bench_batch_addition_
+}
+
+criterion_main!(benches);

arkworks4/tests/batch_addition.rs

@@ -0,0 +1,7 @@
+#[cfg(test)]
+mod tests {
+    use kzg_bench::instantiate_batch_addition_tests;
+    use rust_kzg_arkworks4::eip_7594::ArkBackend;
+
+    instantiate_batch_addition_tests!(ArkBackend);
+}

arkworks5/Cargo.toml

@@ -56,6 +56,10 @@ diskcache = [
     "kzg/diskcache"
 ]
 
+[[bench]]
+name = "batch_addition"
+harness = false
+
 [[bench]]
 name = "fft"
 harness = false

arkworks5/benches/batch_addition.rs

@@ -0,0 +1,15 @@
+use criterion::{criterion_group, criterion_main, Criterion};
+use kzg_bench::benches::batch_addition::bench_batch_addition;
+use rust_kzg_arkworks5::eip_7594::ArkBackend;
+
+fn bench_batch_addition_(c: &mut Criterion) {
+    bench_batch_addition::<ArkBackend>(c)
+}
+
+criterion_group! {
+    name = benches;
+    config = Criterion::default();
+    targets = bench_batch_addition_
+}
+
+criterion_main!(benches);

arkworks5/tests/batch_addition.rs

@@ -0,0 +1,7 @@
+#[cfg(test)]
+mod tests {
+    use kzg_bench::instantiate_batch_addition_tests;
+    use rust_kzg_arkworks5::eip_7594::ArkBackend;
+
+    instantiate_batch_addition_tests!(ArkBackend);
+}

blst/Cargo.toml

@@ -59,6 +59,10 @@ diskcache = [
     "kzg/diskcache"
 ]
 
+[[bench]]
+name = "batch_addition"
+harness = false
+
 [[bench]]
 name = "das"
 harness = false

blst/benches/batch_addition.rs

@@ -0,0 +1,15 @@
+use criterion::{criterion_group, criterion_main, Criterion};
+use kzg_bench::benches::batch_addition::bench_batch_addition;
+use rust_kzg_blst::eip_7594::BlstBackend;
+
+fn bench_batch_addition_(c: &mut Criterion) {
+    bench_batch_addition::<BlstBackend>(c)
+}
+
+criterion_group! {
+    name = benches;
+    config = Criterion::default();
+    targets = bench_batch_addition_
+}
+
+criterion_main!(benches);

blst/tests/batch_addition.rs

@@ -0,0 +1,7 @@
+#[cfg(test)]
+mod tests {
+    use kzg_bench::instantiate_batch_addition_tests;
+    use rust_kzg_blst::eip_7594::BlstBackend;
+
+    instantiate_batch_addition_tests!(BlstBackend);
+}

constantine/Cargo.toml

@@ -54,6 +54,10 @@ wbits = [
 ]
 c_bindings = []
 
+[[bench]]
+name = "batch_addition"
+harness = false
+
 [[bench]]
 name = "das"
 harness = false

constantine/benches/batch_addition.rs

@@ -0,0 +1,15 @@
+use criterion::{criterion_group, criterion_main, Criterion};
+use kzg_bench::benches::batch_addition::bench_batch_addition;
+use rust_kzg_constantine::eip_7594::CtBackend;
+
+fn bench_batch_addition_(c: &mut Criterion) {
+    bench_batch_addition::<CtBackend>(c)
+}
+
+criterion_group! {
+    name = benches;
+    config = Criterion::default();
+    targets = bench_batch_addition_
+}
+
+criterion_main!(benches);

constantine/tests/batch_addition.rs

@@ -0,0 +1,7 @@
+#[cfg(test)]
+mod tests {
+    use kzg_bench::instantiate_batch_addition_tests;
+    use rust_kzg_constantine::eip_7594::CtBackend;
+
+    instantiate_batch_addition_tests!(CtBackend);
+}

kzg-bench/src/benches/batch_addition.rs

@@ -0,0 +1,39 @@
+use criterion::{BatchSize, Criterion};
+use kzg::{msm::batch_addition::multi_batch_addition_binary_tree_stride, EcBackend, G1Affine, G1};
+use rand::{thread_rng, Rng};
+
+pub fn bench_batch_addition<B: EcBackend>(c: &mut Criterion) {
+    let batches = 32usize;
+    let numpoints = 1usize << 14;
+
+    let mut rng = thread_rng();
+
+    let points = (0..batches)
+        .map(|_| {
+            let mut pts = (0..numpoints)
+                .map(|_| B::G1Affine::into_affine(&B::G1::rand()))
+                .collect::<Vec<_>>();
+
+            for _ in 0..rng.gen_range(3..10) {
+                pts[rng.gen_range(0..numpoints)] = B::G1Affine::zero();
+            }
+
+            pts
+        })
+        .collect::<Vec<_>>();
+
+    c.bench_function("multi_batch_addition_binary_tree_stride", |b| {
+        b.iter_batched(
+            || points.clone(),
+            |points| {
+                multi_batch_addition_binary_tree_stride::<
+                    B::G1,
+                    B::G1Fp,
+                    B::G1Affine,
+                    B::G1ProjAddAffine,
+                >(points)
+            },
+            BatchSize::SmallInput,
+        );
+    });
+}

kzg-bench/src/benches/mod.rs

@@ -1,3 +1,4 @@
+pub mod batch_addition;
 pub mod das;
 pub mod eip_4844;
 pub mod eip_7594;