Open
Conversation
ArtiomTr
force-pushed
the
feature/optimize-batch-addition
branch
7 times, most recently
from
b30d0ae to
6bdfa4e
Compare
ArtiomTr
force-pushed
the
feature/optimize-batch-addition
branch
2 times, most recently
from
a635639 to
eb6e338
Compare
Moved batch addition into separate file, in order to implement tests and benchmarks for it. Tests are covering most of the edge cases, including: * P=-Q pairs * P+O pairs * O+O pairs And combinations.
Batch addition performance was optimized while covering necessary edge cases. Now, batch addition handles infinity points (and combinations) without performance regressions.
ArtiomTr
force-pushed
the
feature/optimize-batch-addition
branch
from
eb6e338 to
f9d3ef3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.