Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
100 commits
Select commit Hold shift + click to select a range
723067f
introduce FrozenKeyIdxBiMap data structure
mabruzzo Nov 19, 2025
cdecbb5
address clang-tidy issues
mabruzzo Nov 19, 2025
ce3c404
a few minor tweaks
mabruzzo Nov 19, 2025
660431f
Refactor for consistency with other internal types
mabruzzo Nov 19, 2025
1f42941
restore clang-tidy setting from a few commits back
mabruzzo Nov 19, 2025
a6aa793
apply clang-format
mabruzzo Nov 19, 2025
19d4f7e
a minor tweak to rerun CI
mabruzzo Nov 19, 2025
9d2b9cf
convert interp_table_utils.{h->hpp}
mabruzzo Dec 8, 2025
d7727b3
apply clang-format to src/clib/interp_table_utils.hpp
mabruzzo Dec 8, 2025
0cd4082
shift 2 functions out of src/clib/initialize_chemistry_data into inte…
mabruzzo Dec 8, 2025
fc6983d
Merge branch 'ncc/FrozenKeyIdxBiMap' into ncc/GrainMetalInjectPathways
mabruzzo Dec 8, 2025
44438b7
Begin introducing GrainMetalInjectPathways
mabruzzo Nov 5, 2025
dac21ea
an incremental step towards adopting GrainMetalInjectPathways
mabruzzo Nov 6, 2025
43e2464
another step
mabruzzo Nov 6, 2025
e67ee1b
transition to using grain_yields stored within GrainMetalInjectPathways
mabruzzo Nov 6, 2025
40031e6
calc_grain_size_increment_species_1d: comment the code and add a very…
mabruzzo Nov 12, 2025
55aa77a
remove some commented out debugging code from calc_grain_size_increme…
mabruzzo Nov 12, 2025
97f90d5
minor tweaks
mabruzzo Nov 12, 2025
c1a54e3
add more commentary to calc_grain_size_increment_1d
mabruzzo Nov 14, 2025
2a1a6d5
spruce up some commentary
mabruzzo Nov 14, 2025
a92e11d
add some commentary explaining how calc_tdust_1d_g.F actually works
mabruzzo Nov 14, 2025
d251a23
lay ground work for size_moments
mabruzzo Nov 14, 2025
024c0da
incremental commit
mabruzzo Nov 15, 2025
2a56c85
light refactoring
mabruzzo Dec 5, 2025
74ded6e
shift around some files
mabruzzo Dec 5, 2025
ffe87a5
move some machinery out of initialize_dust_yields.cpp
mabruzzo Dec 5, 2025
be60a50
incremental progress
mabruzzo Dec 5, 2025
08ecd6b
Major progress in restructuring format of injection pathway raw data
mabruzzo Dec 6, 2025
22c981d
confirm new src for total nuclide yields is correct
mabruzzo Dec 6, 2025
29b6028
confirm new src for gas nuclide yields is correct
mabruzzo Dec 6, 2025
5b1f50b
finish transition to newer datasource for metal nuclide yields
mabruzzo Dec 6, 2025
29f04c2
pull out zeroing logic (inject-rates) 1 of 2
mabruzzo Dec 6, 2025
0b95a9c
pull out zeroing logic (inject-rates) 2 of 2
mabruzzo Dec 6, 2025
ff118a5
add temporary machinery in preparation for transition in grain data s…
mabruzzo Dec 6, 2025
0b74a6b
fixed a major error in the reformated tables of injection model data …
mabruzzo Dec 6, 2025
53e79fd
A little more work on the machinery between the new and the old injec…
mabruzzo Dec 6, 2025
9871e85
another check of correctness
mabruzzo Dec 6, 2025
6eb164e
remove the older injection model data organization
mabruzzo Dec 6, 2025
8af2e5e
finish replacing my_rates->SN0_[fX]<metal-nuclide>
mabruzzo Dec 7, 2025
7a61b34
incremental commit
mabruzzo Dec 7, 2025
d5cac76
rm erroneous docstring comment
mabruzzo Dec 8, 2025
1d49a42
introduce all remaining members GrainMetalInjectPathways (they aren't…
mabruzzo Dec 8, 2025
4766aa7
a large step towards changing how opacity coefficients get stored
mabruzzo Dec 8, 2025
6468b3b
another massive step towards removing SN0_kp<grain> and SN0_r0<grain>
mabruzzo Dec 8, 2025
4eee4ee
finish removing SN0_kp<grain> and SN0_r0<grain>
mabruzzo Dec 8, 2025
762e53c
remove SN0_f<grain-species>
mabruzzo Dec 8, 2025
57caed7
remove gr_dT
mabruzzo Dec 8, 2025
d0a3748
Some steps towards removing gr_N and gr_Size
mabruzzo Dec 9, 2025
30fee62
finish removing gr_N and gr_Size
mabruzzo Dec 9, 2025
b9f7893
remove SN0_N
mabruzzo Dec 9, 2025
8dccc0e
remove gr_Td
mabruzzo Dec 9, 2025
24748cb
tweak signature of f_wrap::calc_grain_size_increment_1d
mabruzzo Dec 9, 2025
3825dc7
tweak signature of make_consistent
mabruzzo Dec 9, 2025
bb6cec6
delete grackle::impl::free_dust_yields
mabruzzo Dec 9, 2025
9e9bcfd
slightly simplify zero-out logic
mabruzzo Dec 9, 2025
b79ba75
start using FrozenKeyIdxBiMap for model names
mabruzzo Dec 9, 2025
51610dd
lightly refactor loading of metal nuclide yields
mabruzzo Dec 9, 2025
24ff4ce
confirm that just loading the relevant dust species produces the corr…
mabruzzo Dec 9, 2025
6f913fa
Merge branch 'ncc/FrozenKeyIdxBiMap' into ncc/refactor-GrainSpeciesInfo
mabruzzo Dec 9, 2025
18020b6
use FrozenKeyIdxBiMap within GrainSpeciesInfo (1/3)
mabruzzo Dec 10, 2025
00865dd
use FrozenKeyIdxBiMap within GrainSpeciesInfo (2/3)
mabruzzo Dec 10, 2025
fa08c26
use FrozenKeyIdxBiMap within GrainSpeciesInfo (3/3)
mabruzzo Dec 10, 2025
899f4a2
Merge branch 'ncc/refactor-GrainSpeciesInfo' into ncc/GrainMetalInjec…
mabruzzo Dec 10, 2025
89f3f35
switch to using a map of grain species
mabruzzo Dec 10, 2025
45d2d14
add a few comments and a little assorted refactoring
mabruzzo Dec 10, 2025
d0d8a92
rename initialize_dust_yields -> load_data
mabruzzo Dec 10, 2025
51a5573
some light cleanup of inject_model/load_data.cpp
mabruzzo Dec 10, 2025
947faab
apply clang-format
mabruzzo Dec 10, 2025
d8137d6
update Makefile to remove object files in subdirectories
mabruzzo Dec 10, 2025
eca5fb0
another tweak to `make clean`
mabruzzo Dec 10, 2025
38a1685
Introduce ``InjectPathFieldPack`` 1/3
mabruzzo Dec 10, 2025
530aae3
Introduce ``InjectPathFieldPack`` 2/3
mabruzzo Dec 10, 2025
f6bf246
Introduce ``InjectPathFieldPack`` 3/3
mabruzzo Dec 10, 2025
522b412
calc_grain_size_increment: replace some array operations with explici…
mabruzzo Dec 10, 2025
ebc95d5
calc_grain_size_increment: replace some array operations with explici…
mabruzzo Dec 10, 2025
1c7b5bb
calc_grain_size_increment: replace some array operations with explici…
mabruzzo Dec 10, 2025
70c13f4
initial commit of transcribed calc_grain_size_increment_1d.hpp
mabruzzo Dec 11, 2025
7b39ac6
remove the original fortran version of calc_grain_size_increment_1d
mabruzzo Dec 11, 2025
b97ec42
significantly simplify src/clib/dust/multi_grain_species/calc_grain_s…
mabruzzo Dec 11, 2025
5572b10
adjusting interface of calc_grain_size_increment_1d.hpp
mabruzzo Dec 11, 2025
b12e22e
another interface adjustment
mabruzzo Dec 11, 2025
d86f7e5
a third interface adjustment
mabruzzo Dec 11, 2025
43aa1c2
remove the old wrapper for calc_grain_size_increment_1d.hpp
mabruzzo Dec 11, 2025
35aebcf
replace constants with GrainSpeciesInfoEntry::bulk_density_cgs
mabruzzo Dec 11, 2025
6bbcda7
grain_size_incr: a step towards aggregating allocations
mabruzzo Dec 11, 2025
db4bb63
grain_size_incr: another step towards aggregating allocations
mabruzzo Dec 11, 2025
9bfe7c1
grain_size_incr: a 3rd step towards aggregating allocations
mabruzzo Dec 11, 2025
2cc450b
grain_size_incr: more massaging
mabruzzo Dec 11, 2025
17df793
grain_size_incr: fold all calls to actually compute increment into fo…
mabruzzo Dec 11, 2025
0588e02
incremental commit
mabruzzo Dec 11, 2025
c5b2cfd
another step
mabruzzo Dec 11, 2025
08fbb8e
some extra changes
mabruzzo Dec 11, 2025
2708a54
grain_size_incr: cleanup indexing 1/3
mabruzzo Dec 11, 2025
8d60001
grain_size_incr: cleanup indexing 2/3
mabruzzo Dec 11, 2025
f2e36fc
grain_size_incr: cleanup indexing 3/3
mabruzzo Dec 11, 2025
989b14a
add a bunch of commentary
mabruzzo Dec 11, 2025
2fe019c
add a little more commentary
mabruzzo Dec 11, 2025
ba2009b
apply clang-format
mabruzzo Dec 11, 2025
1671ee3
Refactor last part of calc_grain_size_increment_1d
mabruzzo Dec 11, 2025
c2b7da0
Only load needed injection pathway data
mabruzzo Dec 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .clang-format-ignore
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,9 @@ src/clib/init_misc_species_cool_rates.cpp
src/clib/initialize_UVbackground_data.c
src/clib/initialize_chemistry_data.cpp
src/clib/initialize_cloudy_data.c
src/clib/initialize_dust_yields.cpp
src/clib/initialize_rates.cpp
src/clib/internal_types.hpp
src/clib/internal_units.h
src/clib/interp_table_utils.h
src/clib/interpolate.hpp
src/clib/phys_constants.h
src/clib/rate_functions.c
Expand Down
2 changes: 1 addition & 1 deletion CMakePresets.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"cacheVariables" : {
"CMAKE_COMPILE_WARNING_AS_ERROR": "ON",
"CMAKE_C_FLAGS": "-Wall -Wpedantic -Wextra -Wno-error=unused-variable -Wno-error=newline-eof -Wno-unused-parameter",
"CMAKE_CXX_FLAGS": "-Wall -Wpedantic -Wno-c++17-attribute-extensions -Wno-unused-parameter"
"CMAKE_CXX_FLAGS": "-Wall -Wpedantic -Wno-c++17-attribute-extensions -Wno-unused-parameter -Wno-error=self-assign"
}
},
{
Expand Down
10 changes: 7 additions & 3 deletions src/clib/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,16 @@ add_library(Grackle_Grackle
cool_multi_time_g.cpp cool_multi_time_g.h
dust_props.hpp
dust/grain_species_info.cpp dust/grain_species_info.hpp
dust/multi_grain_species/calc_grain_size_increment_1d.hpp
init_misc_species_cool_rates.cpp init_misc_species_cool_rates.hpp
initialize_chemistry_data.cpp
initialize_dust_yields.cpp initialize_dust_yields.hpp
initialize_rates.cpp initialize_rates.hpp
inject_model/grain_metal_inject_pathways.hpp
inject_model/inject_path_field_pack.hpp
inject_model/load_data.cpp inject_model/load_data.hpp
inject_model/raw_data.cpp inject_model/raw_data.hpp
internal_types.cpp internal_types.hpp
interp_table_utils.hpp
lookup_cool_rates1d.hpp
make_consistent.cpp make_consistent.hpp
opaque_storage.hpp
Expand All @@ -126,6 +131,7 @@ add_library(Grackle_Grackle
solve_rate_cool_g-cpp.cpp solve_rate_cool_g-cpp.h
step_rate_newton_raphson.hpp
time_deriv_0d.hpp
utils/FrozenKeyIdxBiMap.hpp
utils-cpp.cpp utils-cpp.hpp
utils-field.hpp
fortran_func_wrappers.hpp
Expand Down Expand Up @@ -173,11 +179,9 @@ add_library(Grackle_Grackle
grackle_chemistry_data_fields.def # <-- acts as a C header
grackle_macros.h
index_helper.h
interp_table_utils.h
phys_constants.h
collisional_rxn_rate_members.def # <-- acts as a C header
utils.h
dust_const.def

# Fortran public headers
../include/grackle.def
Expand Down
3 changes: 2 additions & 1 deletion src/clib/Make.config.objects
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,11 @@ OBJS_CONFIG_LIB = \
index_helper.lo \
initialize_chemistry_data.lo \
initialize_cloudy_data.lo \
initialize_dust_yields.lo \
init_misc_species_cool_rates.lo \
initialize_rates.lo \
initialize_UVbackground_data.lo \
inject_model/load_data.lo \
inject_model/raw_data.lo \
interpolators_g.lo \
make_consistent.lo \
scale_fields.lo \
Expand Down
4 changes: 3 additions & 1 deletion src/clib/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -338,8 +338,10 @@ install:
#-----------------------------------------------------------------------

clean:
-@rm -f *.la .libs/* *.o *.lo DEPEND.bak *~ $(OUTPUT) *.exe DEPEND out.make.DEPEND
-@rm -f *.la DEPEND.bak *~ $(OUTPUT) *.exe DEPEND out.make.DEPEND
-@rm -rf $(AUTOGEN_DIR)
-@find . -type d -name '.libs' -exec rm -rf '{}' +
-@find . \( -name '*.o' -o -name '*.lo' \) -exec rm -f '{}' \;
-@touch DEPEND

#-----------------------------------------------------------------------
Expand Down
Loading