[newchem-cpp] Only load needed injection pathway data #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some unforunate consequences, but if we don't do this you end up with some pretty confusing looking code... (the confusion primarily arises if new_FrozenKeyIdxBiMap or drop_FrozenKeyIdxBiMap has different behavior from other functions with similar names). I really think it would be better to make this into a simple C++ class with a constructor and destructor, but thats a topic for another time
…rp_table_utils.hpp
There's still a lot of work to be done (the type is incomplete and isn't filled by anything at all)
We don't yet use the new format, but we are just about ready to start doing so
Use the start_idx and stop_idx members to simplify make_consistent
…t for-loops PART 2
…t for-loops PART 3
…ize_increment_1d.hpp
I was expecting this to cause gold-standard drift (but that doesn't seem to be the case)
Previously, if we used metal chemistry, we loaded all injection pathway data. Now we just load what we need. Relatedly, when we index into an array and each member corresponds to a distinct injection pathway, index 0 is now always valid. For context, when my_chemistry->multi_metals is 0, we would historically need to access the relvant data at the index specified by my_chemistry->metal_abundances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after #464 has been merged
This PR stops loading unused injection pathway data
Previously, if we used metal chemistry, we loaded all injection pathway data. Now we just load what we need. Relatedly, when we index into an array and each member corresponds to a distinct injection pathway, index 0 is now always valid. (For context, when
my_chemistry->multi_metalsis 0, we would historically need to access the relevant data at the index specified bymy_chemistry->metal_abundances.)