[newchem-cpp] transcribe calc_grain_size_increment_1d
#464
+6,841
−5,431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some unforunate consequences, but if we don't do this you end up with some pretty confusing looking code... (the confusion primarily arises if new_FrozenKeyIdxBiMap or drop_FrozenKeyIdxBiMap has different behavior from other functions with similar names). I really think it would be better to make this into a simple C++ class with a constructor and destructor, but thats a topic for another time
…InfoEntry This information will only be used after we transcribe `calc_grain_size_increment_1d` (at which point we will remove the corresponding constants from phys_constants.h and can entirely delete the dust_const.def file
…e readability (and add some comments)
I moved them from initialize_dust_yields.cpp where the comments were out of place to dust/grain_species_info.cpp
…rp_table_utils.hpp
There's still a lot of work to be done (the type is incomplete and isn't filled by anything at all)
…ize_increment_1d.hpp
mabruzzo
added
the
refactor
mabruzzo
changed the title
calc_grain_size_increment_1d
I was expecting this to cause gold-standard drift (but that doesn't seem to be the case)
mabruzzo
force-pushed
the
ncc/transcribe_calc_grain_size_increment_1d
branch
from
554e23a to
1671ee3
Compare
Collaborator
Author
|
ASIDE: I noticed that the dust-grain freefall test all systematically take slightly less time (think 0.2-0.4 seconds) than on the current HEAD of newchem-cpp. It's hard to definitively identify the source of speedup, but I think its because I cut a lot of unnecessary allocations out of this function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be reviewed after PR #463 is merged
This PR transcribes
calc_grain_size_increment_1d. I couldn't help myself -- I cleaned up a bunch of logic (folding lots of logic that was explicitly repeated for every kind of injection pathway or for every kind of dust species into for-loops).As of this PR, there is no logic outside of the
inject_modelsubdirectory that directly references injection pathways by name. In other words, we are pretty close to being able to let users load an arbitrary set of injection pathways.