[newchem-cpp] Deduplicate the coolunit calculation in initialize_cloudy_data.cpp
#459
+1,850
−791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes a few more changes than I initially wanted
This was spurred on by deprecation warnings included on macOS's implementation of the standard library
Previously, InternalGrUnits only needed to swap between 2 values so we used a switch of 0 or 1. But, now we have added support for a 3rd value of the Hydrogen Mass (i.e. the value historically used to compute units for the cloudy table). Now that we have 3 values, we define an enum. Don't forget, this is all temporary. The time is rapidly approaching when we will be to transition to just having a single definition for the hydrogen mass constant.
mabruzzo
added
the
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be reviewed after #455 is merged
This is a lightweight PR consisting of 2 commits that replaced the logic in
initialize_cloudy_data.cppfor computingCoolUnitwith equivalent logic that constructs an instance ofInternalGrUnitsand then reads thecoolunitmember. Essentially, this is another step towards having a single source of truth for computing code unit conversions.Aside: I have preserved the unique value of the hydrogen mass used in these calculations so that answer tests won't drift. But, the day is quickly approaching when we will be able to have a single hydrogen mass constant used throughout the codebase.