Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions app/frontend/entrypoints/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,15 @@ import {
installAnalyticsScript,
sendPageViewEvent,
attachExternalLinkTracker,
attachQuestionXsRoutesTracker
attachQuestionXsRoutesTracker,
attachOptionalLinkTracker
} from '../javascript/google-tag'
import { saveConsentStatus } from '../javascript/utils/cookie-consent'
import ajaxMarkdownPreview from '../javascript/ajax-markdown-preview'

document
.querySelectorAll('[data-module="copy-to-clipboard"]')
.forEach(element => {
.forEach((element) => {
copyToClipboard(
element,
element.querySelector('[data-copy-target]'),
Expand All @@ -24,7 +25,7 @@ document

document
.querySelectorAll('[data-module="markdown-editor-toolbar"]')
.forEach(element => {
.forEach((element) => {
markdownEditorToolbar(
element,
JSON.parse(element.getAttribute('data-i18n')),
Expand All @@ -35,7 +36,7 @@ document

document
.querySelectorAll('[data-module="ajax-markdown-preview"]')
.forEach(element => {
.forEach((element) => {
ajaxMarkdownPreview(
element.querySelector('[data-ajax-markdown-target]'),
element.querySelector('[data-ajax-markdown-source]'),
Expand All @@ -50,6 +51,7 @@ if (document.body.dataset.googleAnalyticsEnabled === 'true') {
sendPageViewEvent()
attachExternalLinkTracker()
attachQuestionXsRoutesTracker()
attachOptionalLinkTracker()
}

initAll()
Expand Down
23 changes: 22 additions & 1 deletion app/frontend/javascript/google-tag/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export function installAnalyticsScript (global) {
const GTAG_ID = 'GTM-MFJWJNW'
if (!window.ga) {
;(function (w, d, s, l, i) {
(function (w, d, s, l, i) {
w[l] = w[l] || []
w[l].push({
'gtm.start': new Date().getTime(),
Expand Down Expand Up @@ -68,6 +68,27 @@ export function attachExternalLinkTracker () {
})
}

export function attachOptionalLinkTracker () {
const linksToTrack = document.querySelectorAll('a[data-track-link]')
linksToTrack.forEach(function (link) {
link.addEventListener('click', function (event) {
const target = event.target
const external = target.getAttribute('href').startsWith('http')
window.dataLayer.push({
event: 'event_data',
event_data: {
event_name: 'navigation',
external,
method: 'primary click',
text: target.textContent,
type: 'generic link',
url: target.href
}
})
})
})
}

export function attachQuestionXsRoutesTracker () {
const showRoutesPathRegex = /^\/forms\/\d+\/pages\/\d+\/routes$/
const path = window.location.pathname
Expand Down
117 changes: 115 additions & 2 deletions app/frontend/javascript/google-tag/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import {
sendPageViewEvent,
attachExternalLinkTracker,
setDefaultConsent,
attachQuestionXsRoutesTracker
attachQuestionXsRoutesTracker,
attachOptionalLinkTracker
} from '../google-tag'
import { describe, afterEach, it, expect, beforeEach } from 'vitest'

Expand Down Expand Up @@ -151,7 +152,7 @@ describe('google_tag.mjs', () => {
data: 'Some existing data in the dataLayer'
}

const preventDefault = event => {
const preventDefault = (event) => {
event.preventDefault()
}

Expand Down Expand Up @@ -243,4 +244,116 @@ describe('google_tag.mjs', () => {
})
})
})

describe('attachOptionalLinkTracker', () => {
const preventDefault = (event) => {
event.preventDefault()
}
beforeEach(() => {
document.body.innerHTML = `
<a id="externalHTTP" href="http://example.com/" data-track-link>A link to example.com</a>
<a id="noTrack" href="http://example.com/">A link to example.com</a>
<a id="externalHTTPS" href="https://example.com/" data-track-link>A secure link to example.com</a>
<a id="internal" href="a_csv_file.csv" data-track-link>Dpwnload a CSV file</a>
<a id="mailto" href="mailto:example@example.com" data-track-link>A link to example@example.com</a>
`
window.dataLayer = []

// stop link clicks from navigating, since jsdom can't do navigation
document.querySelector('a').addEventListener('click', preventDefault)
})

afterEach(() => {
document.querySelector('a').removeEventListener('click', preventDefault)
window.dataLayer = []
})

it('tracks clicks on external HTTP link with data-track-link attribute', () => {
attachOptionalLinkTracker()

const externalLink = document.getElementById('externalHTTP')
externalLink.click()
expect(window.dataLayer).toEqual([
{
event: 'event_data',
event_data: {
event_name: 'navigation',
external: true,
method: 'primary click',
text: 'A link to example.com',
type: 'generic link',
url: 'http://example.com/'
}
}
])
})

it('tracks clicks on external HTTPS link with data-track-link attribute', () => {
attachOptionalLinkTracker()

const externalLink = document.getElementById('externalHTTPS')
externalLink.click()
expect(window.dataLayer).toEqual([
{
event: 'event_data',
event_data: {
event_name: 'navigation',
external: true,
method: 'primary click',
text: 'A secure link to example.com',
type: 'generic link',
url: 'https://example.com/'
}
}
])
})

it('tracks clicks on internal link with data-track-link attribute', () => {
attachOptionalLinkTracker()

const internalLink = document.getElementById('internal')
internalLink.click()
expect(window.dataLayer).toEqual([
{
event: 'event_data',
event_data: {
event_name: 'navigation',
external: false,
method: 'primary click',
text: 'Dpwnload a CSV file',
type: 'generic link',
url: 'http://localhost:3000/a_csv_file.csv'
}
}
])
})

it('does not track clicks on links without data-track-link attribute', () => {
attachOptionalLinkTracker()

const link = document.getElementById('noTrack')
link.click()
expect(window.dataLayer).toEqual([])
})

it('tracks clicks on mailto link with data-track-link attribute', () => {
attachOptionalLinkTracker()

const link = document.getElementById('mailto')
link.click()
expect(window.dataLayer).toEqual([
{
event: 'event_data',
event_data: {
event_name: 'navigation',
external: false,
method: 'primary click',
text: 'A link to example@example.com',
type: 'generic link',
url: 'mailto:example@example.com'
}
}
])
})
})
})
2 changes: 1 addition & 1 deletion app/views/forms/welsh_translation/new.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</h1>

<div class="govuk-button-group">
<%= govuk_button_link_to t(".csv_download"), welsh_translation_download_path(@welsh_translation_input.form), secondary: true %>
<%= govuk_button_link_to t(".csv_download"), welsh_translation_download_path(@welsh_translation_input.form, format: :csv), secondary: true, data: { "track-link": true } %>
<%= render PreviewLinkComponent::View.new(@welsh_translation_input.form.pages, preview_link(@welsh_translation_input.form, locale: :cy), t(".preview_link_text")) %>
</div>
</div>
Expand Down
Loading