Open
Conversation
Only external links are tracked through google analytics. This commit adds a new javascript function to track clicks on links with the data-track-link attribute. Adding this attribute to a link, either external or internal, will cause the link to be tracked by google analytics. For example: <a href="/path" data-track-link>Link text</a> It's also possible to add it to mailto or tel links. The event has a set schema so would show in the GA dashboard as a navigation event and as a 'generic link'. That might not be what you want.
We want to track clicks on the Welsh download CSV link, to see if people are using it. Add a track-link to the Welsh translation CSV download link.
We modify the welsh translation download link to include the .csv extension. This might make it easier to track the link in Google Analytics.
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2671.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track the CSV download on the Welsh translation page
Trello card: https://trello.com/c/oIf48Bv9/2862-add-google-analytics-event-for-downloading-the-translation-spreadsheet
This PR adds some new javascript to track links which have the
data-track-linkattribute set.For example:
It then adds this attribute to the Welsh CSV download link so that it should be tracked, in the same way we track external links.
It also adds the CSV format to the Welsh download link, to make it clearer that it's a CSV file.
Things to consider when reviewing