Skip to content

Update list of forms to include indication of Welsh versions#2651

Open
alice-carr wants to merge 1 commit intomainfrom
update-list-to-include-welsh-versions
Open

Update list of forms to include indication of Welsh versions#2651
alice-carr wants to merge 1 commit intomainfrom
update-list-to-include-welsh-versions

Conversation

@alice-carr
Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

form list now includes text underneath the form name to indicate if the form has a welsh version, and if that version is live archived or draft

Trello card: https://trello.com/c/kJZuRxGT/2893-update-list-of-forms-to-include-indication-of-welsh-versions
Screenshot 2026-03-24 at 13 40 41
Screenshot 2026-03-24 at 13 40 57

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@alice-carr alice-carr force-pushed the update-list-to-include-welsh-versions branch from 86e1a35 to e84c517 Compare March 24, 2026 15:18
@sonarqubecloud
Copy link
Copy Markdown

@alice-carr alice-carr marked this pull request as ready for review March 24, 2026 15:40
thomasiles
thomasiles previously approved these changes Mar 25, 2026
Copy link
Copy Markdown
Contributor

@thomasiles thomasiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@alice-carr alice-carr force-pushed the update-list-to-include-welsh-versions branch from e84c517 to 70c263e Compare March 30, 2026 14:49
form list now includes text underneath the form name to indicate if the form has a welsh version, and if that version is live archived or draft
@alice-carr alice-carr force-pushed the update-list-to-include-welsh-versions branch from 70c263e to 4956c9c Compare March 30, 2026 14:57
@github-actions
Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2651.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants