Skip to content

Make the error message when an unrecognized attribute is used in a Buildable more useful. #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 21, 2025
Merged

Make the error message when an unrecognized attribute is used in a Buildable more useful. #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion fiddle/_src/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,11 @@ def __getattr__(self, name: str):
)
if param is not None and param.default is not param.empty:
return param.default
msg = f"No parameter '{name}' has been set on {self!r}."
msg = (
f"No parameter '{name}' has been set on {self!r} "
f"(Buildable='{self.__fn_or_cls__.__qualname__}', missing "
f"parameter='{name}')."
)
# TODO(b/219988937): Implement an edit distance function and display valid
# attributes that are close to `name`.
if hasattr(self.__fn_or_cls__, name):
Expand Down
7 changes: 5 additions & 2 deletions fiddle/_src/config_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,8 +843,11 @@ def test_repr_varkwargs(self):

def test_nonexistent_attribute_error(self):
class_config = fdl.Config(SampleClass, 1)
expected_msg = (r"No parameter 'nonexistent_arg' has been set on "
r'<Config\[SampleClass\(arg1=1\)\]>\.')
expected_msg = (
r"No parameter 'nonexistent_arg' has been set on "
r'<Config\[SampleClass\(arg1=1\)\]> \(Buildable='
r"'SampleClass', missing parameter='nonexistent_arg'\)."
)
with self.assertRaisesRegex(AttributeError, expected_msg):
getattr(class_config, 'nonexistent_arg')

Expand Down