Make the error message when an unrecognized attribute is used in a Buildable more useful.#593
Merged
copybara-service[bot] merged 1 commit intomainfrom Oct 21, 2025
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_819920081
branch
2 times, most recently
from
94bc97d to
04057e1
Compare
…ildable more useful. We often deal with configs with 1k+ lines and this common error message puts the missing attribute at the top before printing out the entire Buildable. At best, it is difficult to figure out the missing attribute, but usually, it is beyond the pagination limit. This change explicitly lists the Buildable's qualified name and missing attribute at the end so it is easy to identify. PiperOrigin-RevId: 822097405
copybara-service
bot
force-pushed
the
test_819920081
branch
from
04057e1 to
4954405
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the error message when an unrecognized attribute is used in a Buildable more useful.
We often deal with configs with 1k+ lines and this common error message puts the missing attribute at the top before printing out the entire Buildable. At best, it is difficult to figure out the missing attribute, but usually, it is beyond the pagination limit. This change explicitly lists the Buildable's qualified name and missing attribute at the end so it is easy to identify.