Skip symbol tables with invalid string table links #467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering a symbol table (SYMTAB or DYNSYM) whose sh_link field
does not point to a valid string table (STRTAB) section, bloaty would
previously throw an error and stop. This caused bloaty to fail on some
binaries, such as U-Boot, which have such sections.
This change modifies bloaty to warn about the invalid section and skip
it, allowing processing to continue. This matches the behavior of other
tools like readelf, which warn but do not fail on such binaries.
A lit test is also included.
Confirmed that
bloatycan now readu-bootwithout throwing an error:Fixes #130