Allow undefined symbol names #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing symbol table names an error would be thrown if the the name was undefined (0) resulting in failures to process files like: > bloaty: can't read index 0 from strtab, total size is 254049 This modifies the symbol table processing to return an empty string if the name is undefined. An empty string will trigger the existing logic to generate a synthetic "Anonymous" name instead of crashing. Fixes: google#217 Fixes: google#345
Adds a lit test to make sure an "Anonymous" entry is emitted if a symbol table entry has an undefined name.
Collaborator
Author
haberman
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing symbol table names an error would be thrown if the the
name was undefined (0) resulting in failures to process files like:
This modifies the symbol table processing to return an empty string if
the name is undefined. An empty string will trigger the existing logic
to generate a synthetic "Anonymous" name instead of crashing.
Fixes: #217
Fixes: #345