fix: SceneBuilder will not load missing files from recent projects.

[Oliver-Loeffler]

Scene Builder will ask to remove missing files from recent files list.
Welcome Page will not close, there will not be an error message.

Issue

Fixes #582

Progress

• Change must not contain extraneous whitespace
• License header year is updated, if required
• The PR name must follow the pre-defined format
• Verify the contributor has signed Gluon Individual Contributor License Agreement (CLA)

[Oliver-Loeffler]

Bildschirmaufnahme.2022-10-10.um.23.58.04-1.mov

Window positioning is not yet okay. I am hesitating to touch the AlertDialog for this. Something like positionCentralOver or so could be helpful.

[abhinayagarwal]

The new tests added to the app project doesn't seem to run.

[Oliver-Loeffler]

I've moved the surefire-plugin from kit/POM.xml to POM.xml so that now tests of app and kit are executed during Maven build.

[Oliver-Loeffler]

This PR now additionally addresses issue #600 which describes the behavior of unintended closing of SceneBuilder.

[Oliver-Loeffler]

Hi @abhinayagarwal, I have now corrected the POM for app. Tests are running now. Could you please review this one again?

[Oliver-Loeffler]

@AlmasB Hi Almas, may be you also could have a look on this one!

[Oliver-Loeffler]

Happy new year SceneBuilder!
Hope you'll had a good start into 2023.

@abhinayagarwal, could you please review this one again? The tests are now triggered properly.

[abhinayagarwal]

A very happy new year to you too!

Hopefully, I can get back to this PR some time this week.

[abhinayagarwal]

Can you please update the branch with latest changes?

[Oliver-Loeffler]

I've now merged the latest changes into this one. Also applied reformatting according what checkstyle finds for the change files in main.

[abhinayagarwal]

Testing the changes, it looks good on Mac (including the positioning). However, I find the text on the buttons to be too descriptive for a dialog.

Here is a screenshot from IntelliJ IDEA of a dialog when project is not found:

[Oliver-Loeffler]

Thanks, very good example. Well I will rework it accordingly tonight.

[Oliver-Loeffler]

With the reworked ErrorDialog it is also now possible to have a useful title for the error detail. Also in SceneBuilderApp the dialog is now called in such way, so we always have a correct modality and one cannot loose a window.

As mentioned before, the error detail is a detail, the dialog requires user action to open.

Actually, it would be quite useful to add some proper log messages here.

[Oliver-Loeffler]

If this PR gets approved and merged, I'd like to continue with #576 which then would fix #120.

[abhinayagarwal]

LGTM!

[Oliver-Loeffler]

It took a while but actually I am also now happy with the outcome. Thanks for your feedback.

[Oliver-Loeffler]

Thanks for the feedback @abhinayagarwal and @AlmasB. That seems to be okay now. The issues with the error dialog are valid but should be resolved in a separate PR.

[Oliver-Loeffler]

This one fixed also #600.