feat: Enabled loading of FXML files via drag&drop to WelcomeScreen.#591
Closed
Oliver-Loeffler wants to merge 13 commits intogluonhq:masterfrom
Closed
feat: Enabled loading of FXML files via drag&drop to WelcomeScreen.#591Oliver-Loeffler wants to merge 13 commits intogluonhq:masterfrom
Oliver-Loeffler wants to merge 13 commits intogluonhq:masterfrom
Conversation
Collaborator
|
Can we also make sure that Scene Builder doesn't exit if an invalid FXML is dropped or opened? |
Collaborator
Author
Collaborator
Author
|
Hi @abhinayagarwal, Thanks for reviewing. I was wrong with my previous statement and after some reading #585 turned out to be the relevant PR for this. Please have a look at PR #585, this one exactly addresses the issue of error reporting and keeping the Welcome Page open. Its a bit more complex but this is IMHO a good basis for #591. Both combined work quite well. My proposal is to merge PR #585 first, then get the drag&drop one merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature PR introduces drag&drop to the welcome page.
One now can select a group of files and directories and drag them over the welcome page. On drop, the files are filtered to be FXML files and dropped subdirectories are searched for FXML files in first level.
All FXML files found will be passed to the file open process of Scene Builder.
For unsupported files or empty directories no message will be displayed as long as at least one file can be loaded.
If no file can be loaded at all, a message is displayed to the user that there were either unsupported files and/or the selected directories did not contain any supported file.
Issue
Fixes #584
Progress