Skip to content

Allow compressors to be registered with CompressorFactory#4

Closed
melissalinkert wants to merge 1 commit intoglencoesoftware:masterfrom
melissalinkert:registerable-compressor
Closed

Allow compressors to be registered with CompressorFactory#4
melissalinkert wants to merge 1 commit intoglencoesoftware:masterfrom
melissalinkert:registerable-compressor

Conversation

@melissalinkert
Copy link
Copy Markdown
Member

To be considered instead of or in addition to #3. This makes some minimal changes to CompressorFactory to allow additional compression ids to be registered and adds a unit test to verify that registration and lookup works.

@melissalinkert melissalinkert mentioned this pull request Dec 13, 2021
@chris-allan
Copy link
Copy Markdown
Member

FYI, Java SPI being discussed upstream:

@joshmoore
Copy link
Copy Markdown

@melissalinkert : do you want these migrated to https://github.com/zarr-developers/jzarr?

cc: @MSanKeys963 (same for #3)

@melissalinkert
Copy link
Copy Markdown
Member Author

@joshmoore: Yes, this and #3 could be migrated, but I think the differences in glencoesoftware/bioformats2raw#203 (comment) need to be resolved first. I'll try to sort that out this week.

@melissalinkert
Copy link
Copy Markdown
Member Author

Opened upstream: zarr-developers#10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants