Reconcile nested/dimension separator changes#5
Merged
joshmoore merged 2 commits intozarr-developers:mainfrom Jun 14, 2023
Merged
Reconcile nested/dimension separator changes#5joshmoore merged 2 commits intozarr-developers:mainfrom
joshmoore merged 2 commits intozarr-developers:mainfrom
Conversation
Adapted from the initial nested work in 9a1bedb, which was cherry-picked from glencoesoftware@97fc6ef
Adapted from 32bdeef, which was cherry-picked from glencoesoftware@32a10db
joshmoore
approved these changes
May 25, 2023
Member
joshmoore
left a comment
joshmoore
left a comment
There was a problem hiding this comment.
Changes look sensible. Waiting for any other feedback, and then will get this in and start moving toward 0.4.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this covers the changes referenced in glencoesoftware/bioformats2raw#203 (comment), which were picked from glencoesoftware#1. This is a prerequisite for migrating glencoesoftware#4 (comment).
The original commits referenced (from @joshmoore) used a
Boolean nestedto determine the dimension separator. The original commits significantly conflict withmain, as the API here now uses aDimensionSeparatorenum directly. I did not try to cherry-pick and resolve conflicts, but added relevant changes and referenced the original commits in the new commit messages. Hopefully that's reasonably clear.Mostly this is fixing
ArrayParamsandZarrHeaderto really default toDimensionSeparator.DOTif a null was supplied, and expanding the relevant tests to cover all three possibleDimensionSeparatorvalues.