Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions .github/workflows/daily-issues-report.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions .github/workflows/shared/issues-data-fetch.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,14 @@ steps:
# Fetch all issues (open and closed) using gh CLI
# Using --limit 1000 to get the last 1000 issues, unfiltered
echo "Fetching the last 1000 issues..."
gh issue list --repo ${{ github.repository }} \
if ! gh issue list --repo ${{ github.repository }} \
--state all \
--json number,title,author,createdAt,state,url,body,labels,updatedAt,closedAt,milestone,assignees,comments \
--limit 1000 \
> /tmp/gh-aw/issues-data/issues.json
> /tmp/gh-aw/issues-data/issues.json; then
echo "::warning::Failed to fetch issues data (issues may be disabled or temporarily unavailable). Using empty dataset. Downstream analysis will report zero issues — check repository Issues settings or retry the workflow if this is unexpected."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good defensive fallback! The ::warning:: annotation will surface nicely in the GitHub Actions UI. Consider also logging the exit code ($?) for easier debugging when this warning fires.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid defensive approach — wrapping the gh issue list call in an error handler and falling back to an empty JSON array ([]) prevents cascading failures. The warning message is clear and actionable, directing operators to check Issues settings or retry.

echo "[]" > /tmp/gh-aw/issues-data/issues.json
fi

# Generate schema for reference
/tmp/gh-aw/jqschema.sh < /tmp/gh-aw/issues-data/issues.json > /tmp/gh-aw/issues-data/issues-schema.json
Expand Down
12 changes: 10 additions & 2 deletions actions/setup/sh/install_awf_binary.sh
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,15 @@ else
fi

# Verify installation
which awf
awf --version
# Use the absolute path to avoid PATH issues on self-hosted or GPU runners
# where ${AWF_INSTALL_DIR} may not be in the user PATH. The binary is always
# accessible in subsequent steps via sudo (which includes /usr/local/bin).
# Also clear DIFC (Data Integrity and Filtering Controls) proxy env vars
# set by start_difc_proxy.sh. When the DIFC proxy is active, GITHUB_API_URL
# and GITHUB_GRAPHQL_URL point to localhost:18443 and GH_HOST is overridden.
# The AWF bundle may try to reach these endpoints on startup, causing the
# version check to fail with a connection error if the proxy rejects the request.
env -u GITHUB_API_URL -u GITHUB_GRAPHQL_URL -u GH_HOST \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart use of env -u to clear DIFC proxy env vars before the version check. This cleanly avoids the proxy connection failure without modifying the shell environment permanently.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix for the DIFC proxy issue. Unsetting GITHUB_API_URL, GITHUB_GRAPHQL_URL, and GH_HOST before running the version check ensures the AWF binary uses its default endpoints rather than the proxy-overridden ones. This cleanly isolates the verification step from the DIFC proxy environment.

"${AWF_INSTALL_DIR}/${AWF_INSTALL_NAME}" --version

echo "✓ AWF installation complete"
Loading