-
Notifications
You must be signed in to change notification settings - Fork 322
fix: restore Daily Issues Report Generator — AWF binary install + issues data fetch resilience #24349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: restore Daily Issues Report Generator — AWF binary install + issues data fetch resilience #24349
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,11 +49,14 @@ steps: | |
| # Fetch all issues (open and closed) using gh CLI | ||
| # Using --limit 1000 to get the last 1000 issues, unfiltered | ||
| echo "Fetching the last 1000 issues..." | ||
| gh issue list --repo ${{ github.repository }} \ | ||
| if ! gh issue list --repo ${{ github.repository }} \ | ||
| --state all \ | ||
| --json number,title,author,createdAt,state,url,body,labels,updatedAt,closedAt,milestone,assignees,comments \ | ||
| --limit 1000 \ | ||
| > /tmp/gh-aw/issues-data/issues.json | ||
| > /tmp/gh-aw/issues-data/issues.json; then | ||
| echo "::warning::Failed to fetch issues data (issues may be disabled or temporarily unavailable). Using empty dataset. Downstream analysis will report zero issues — check repository Issues settings or retry the workflow if this is unexpected." | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Solid defensive approach — wrapping the |
||
| echo "[]" > /tmp/gh-aw/issues-data/issues.json | ||
| fi | ||
|
|
||
| # Generate schema for reference | ||
| /tmp/gh-aw/jqschema.sh < /tmp/gh-aw/issues-data/issues.json > /tmp/gh-aw/issues-data/issues-schema.json | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -210,7 +210,15 @@ else | |
| fi | ||
|
|
||
| # Verify installation | ||
| which awf | ||
| awf --version | ||
| # Use the absolute path to avoid PATH issues on self-hosted or GPU runners | ||
| # where ${AWF_INSTALL_DIR} may not be in the user PATH. The binary is always | ||
| # accessible in subsequent steps via sudo (which includes /usr/local/bin). | ||
| # Also clear DIFC (Data Integrity and Filtering Controls) proxy env vars | ||
| # set by start_difc_proxy.sh. When the DIFC proxy is active, GITHUB_API_URL | ||
| # and GITHUB_GRAPHQL_URL point to localhost:18443 and GH_HOST is overridden. | ||
| # The AWF bundle may try to reach these endpoints on startup, causing the | ||
| # version check to fail with a connection error if the proxy rejects the request. | ||
| env -u GITHUB_API_URL -u GITHUB_GRAPHQL_URL -u GH_HOST \ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Smart use of
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good fix for the DIFC proxy issue. Unsetting |
||
| "${AWF_INSTALL_DIR}/${AWF_INSTALL_NAME}" --version | ||
|
|
||
| echo "✓ AWF installation complete" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good defensive fallback! The
::warning::annotation will surface nicely in the GitHub Actions UI. Consider also logging the exit code ($?) for easier debugging when this warning fires.