Skip to content

tests: Both Guidepup tests work! #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smockle merged 12 commits into from
Jan 15, 2026
+35 −14
Merged

tests: Both Guidepup tests work! #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a9998ed
wip: Test Guidepup (macOS)
smockle Jan 15, 2026
e4443d0
fix: Go up two directories before attempting to access examples
smockle Jan 15, 2026
23b76be
wip: Check whether VoiceOver AppleScript is available
smockle Jan 15, 2026
dca1e14
wip: Check VoiceOver settings
smockle Jan 15, 2026
8609eb1
fix: Use Firefox instead of Edge, since the polyfill isn't used in th…
smockle Jan 15, 2026
cc120c6
wip: Test Windows
smockle Jan 15, 2026
4691aa5
fix: Go up two directories before attempting to access examples
smockle Jan 15, 2026
3545321
wip: Click textarea before typing
smockle Jan 15, 2026
1aa8481
wip: Try with the 'press right' test
smockle Jan 15, 2026
8eb38c2
revert: wip: Try with the 'press right' test. It still doesn’t work.
smockle Jan 15, 2026
1ab78ba
wip: Prepare for merge
smockle Jan 15, 2026
12e6d6c
wip: Prepare for merge
smockle Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ permissions:
contents: read

jobs:
test:
name: Test
web-test-runner:
name: Web Test Runner
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
Expand All @@ -35,3 +35,17 @@ jobs:
- run: npm ci
- uses: guidepup/setup-action@eefb29916eda6dfda810adc0ac72faea006dbba6
- run: npm run test:guidepup
guidepup-windows:
name: Guidepup (Windows)
runs-on: windows-latest
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 24
registry-url: https://registry.npmjs.org/
cache: npm
- run: npm install -g npm@^11.0.0
- run: npm ci
- uses: guidepup/setup-action@eefb29916eda6dfda810adc0ac72faea006dbba6
- run: npm run test:guidepup
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"files": [],
"scripts": {
"test": "npx playwright install firefox && web-test-runner",
"test:guidepup": "npx playwright test"
"test:guidepup": "npx playwright install firefox && npx playwright test"
},
"devDependencies": {
"@esm-bundle/chai": "^4.3.4-fix.0",
Expand Down
7 changes: 2 additions & 5 deletions playwright.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,8 @@ const config = {
retries: 0,
projects: [
{
name: "Microsoft Edge",
use: {
...devices["Desktop Edge"],
channel: "msedge",
},
name: 'firefox', // Use Firefox because Firefox doesn’t have a native implementation of 'ariaNotify' (as of 2026-01-15), so we can test the polyfill in it.
use: devices['Desktop Firefox'],
},
],
quiet: false,
Expand Down
9 changes: 8 additions & 1 deletion tests/guidepup/nvda.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const test = baseTest.extend({
route.fulfill({
path: path.join(
import.meta.dirname,
"..",
"../..",
new URL(request.url()).pathname
),
})
Expand Down Expand Up @@ -84,6 +84,13 @@ if (process.platform === "win32") {
});

test("SuggestedText", async ({ page }) => {
// Wait for page to load
await page.waitForTimeout(500);

// Focus the textarea and wait for NVDA virtual cursor to move there
await page.getByRole("textbox", { name: "Add a comment" }).click();
await page.waitForTimeout(500);
Comment on lines +91 to +92
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using hard-coded timeouts with waitForTimeout is an anti-pattern that can lead to flaky tests. Consider using more reliable waiting strategies such as waiting for specific elements, network requests, or state changes. For example, you could wait for the textarea to be ready using waitFor with a specific state or condition.

Suggested change
await page.getByRole("textbox", { name: "Add a comment" }).click();
await page.waitForTimeout(500);
const commentTextbox = page.getByRole("textbox", { name: "Add a comment" });
await commentTextbox.click();
await expect(commentTextbox).toBeFocused();

Copilot uses AI. Check for mistakes.

// Type a completable string in the textarea
await nvda.type("a");

Expand Down
13 changes: 8 additions & 5 deletions tests/guidepup/voiceover.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const test = baseTest.extend({
route.fulfill({
path: path.join(
import.meta.dirname,
"..",
"../..",
new URL(request.url()).pathname
),
})
Expand Down Expand Up @@ -44,10 +44,6 @@ if (process.platform === "darwin") {
await page.locator("body").waitFor();
await page.locator("body").focus();

// Navigate to the beginning of the web content.
await voiceOver.interact();
await voiceOver.perform(voiceOver.keyboardCommands.jumpToLeftEdge);

// Clear out logs.
await voiceOver.clearItemTextLog();
await voiceOver.clearSpokenPhraseLog();
Expand All @@ -59,6 +55,13 @@ if (process.platform === "darwin") {
});

test("SuggestedText", async ({ page }) => {
// Wait for page to load
await page.waitForTimeout(500);

// Focus the textarea and wait for VoiceOver cursor to move there
await page.getByRole("textbox", { name: "Add a comment" }).click();
await page.waitForTimeout(500);
Comment on lines +62 to +63
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using hard-coded timeouts with waitForTimeout is an anti-pattern that can lead to flaky tests. Consider using more reliable waiting strategies such as waiting for specific elements, network requests, or state changes. For example, you could wait for the textarea to be ready using waitFor with a specific state or condition.

Suggested change
await page.getByRole("textbox", { name: "Add a comment" }).click();
await page.waitForTimeout(500);
const commentTextbox = page.getByRole("textbox", { name: "Add a comment" });
await commentTextbox.click();
await expect(commentTextbox).toBeFocused();

Copilot uses AI. Check for mistakes.

// Type a completable string in the textarea
await voiceOver.type("a");

Expand Down
Loading