Skip to content

Conversation

@smockle
Copy link
Contributor

@smockle smockle commented Jan 15, 2026

No description provided.

@smockle smockle requested a review from a team as a code owner January 15, 2026 16:31
@smockle smockle changed the title tests: Both Guidepup test work! tests: Both Guidepup tests work! Jan 15, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Guidepup tests for both VoiceOver (macOS) and NVDA (Windows) screen readers. The changes address path resolution issues, add necessary timing delays for screen reader synchronization, and improve CI/CD configuration.

Changes:

  • Fixed file path resolution in test routing by changing from ".." to "../.."
  • Added explicit focus and timing delays to ensure screen reader cursors are properly positioned
  • Switched from Microsoft Edge to Firefox for consistent polyfill testing across all test suites
  • Added Windows-specific Guidepup job to GitHub Actions workflow

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/guidepup/voiceover.spec.mjs Fixed path resolution and added timing delays for VoiceOver cursor synchronization
tests/guidepup/nvda.spec.mjs Fixed path resolution and added timing delays for NVDA virtual cursor synchronization
playwright.config.mjs Switched from Edge to Firefox to ensure consistent polyfill testing
package.json Added Firefox installation to test:guidepup script
.github/workflows/test.yml Renamed job and added Windows-specific Guidepup testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +62 to +63
await page.getByRole("textbox", { name: "Add a comment" }).click();
await page.waitForTimeout(500);
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using hard-coded timeouts with waitForTimeout is an anti-pattern that can lead to flaky tests. Consider using more reliable waiting strategies such as waiting for specific elements, network requests, or state changes. For example, you could wait for the textarea to be ready using waitFor with a specific state or condition.

Suggested change
await page.getByRole("textbox", { name: "Add a comment" }).click();
await page.waitForTimeout(500);
const commentTextbox = page.getByRole("textbox", { name: "Add a comment" });
await commentTextbox.click();
await expect(commentTextbox).toBeFocused();

Copilot uses AI. Check for mistakes.
Comment on lines +91 to +92
await page.getByRole("textbox", { name: "Add a comment" }).click();
await page.waitForTimeout(500);
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using hard-coded timeouts with waitForTimeout is an anti-pattern that can lead to flaky tests. Consider using more reliable waiting strategies such as waiting for specific elements, network requests, or state changes. For example, you could wait for the textarea to be ready using waitFor with a specific state or condition.

Suggested change
await page.getByRole("textbox", { name: "Add a comment" }).click();
await page.waitForTimeout(500);
const commentTextbox = page.getByRole("textbox", { name: "Add a comment" });
await commentTextbox.click();
await expect(commentTextbox).toBeFocused();

Copilot uses AI. Check for mistakes.
@smockle smockle merged commit ab7341f into smockle/test-guidepup Jan 15, 2026
8 of 9 checks passed
@smockle smockle deleted the smockle/tmp-test-guidepup branch January 15, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants