Merged
Conversation
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
When building with the recently-updated `gawk` v5.4.0 using Git for
Windows' fork of the MSYS2 runtime, the invocation of `gentls_offsets`
fails. The unhelpful symptom is:
GEN tlsoffsets
<stdin>:6:37: error: expected initializer before '*' token
<stdin>:6:41: error: expected unqualified-id before '=' token
<stdin>:6:71: error: expected unqualified-id before ')' token
awk: fatal: cannot open file `tlsoffsets' for reading: No such file or directory
/d/a/MSYS2-packages/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/scripts/gentls_offsets: line 104: [: -ne: unary operator expected
The underlying reason is that the bug fix for
git-for-windows/git#2189 interacts badly with
the new gawk version's behavior when setting `LC_ALL` to `C`. The
concrete problem is that:
printf 'void (*func) (int, siginfo_t *, void *);\n' |
gawk '
{
# Filter out function names
print gensub (/\(\*(\w+)\)\s*\([^\)]*\)/, "\\1", "g");
}
'
no longer prints the expected:
void func;
but instead:
void (*func) (int, siginfo_t *, void *);
The worst part is that this patch seems not even necessary to fix the
bug anymore, some other change in the past six years must have gotten
to the true root cause that I must have missed.
Therefore, I _will_ revert that patch, but in the meantime I also have
to work around the current build failure because I have to build a new
MSYS2 runtime to fix the bug that prevents the MSYS2 runtime from being
built correctly, a classic Catch-22.
Let's just force `LC_ALL=C.UTF-8` specifically for `gawk`. We can
always drop that work-around later, once a fixed MSYS2 runtime is
deployed.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
|
/deploy |
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corresponds to git-for-windows/msys2-runtime#127