Revert bogus bug fix that prevented the deployment of v3.6.7 at first#128
Open
dscho wants to merge 1 commit intogit-for-windows:mainfrom
Open
Revert bogus bug fix that prevented the deployment of v3.6.7 at first#128dscho wants to merge 1 commit intogit-for-windows:mainfrom
dscho wants to merge 1 commit intogit-for-windows:mainfrom
Conversation
This was designed to fix the problem where double-clicking `.sh` scripts in Windows Explorer with non-ASCII filenames would not execute the scripts, see git-for-windows/git#2189 However, this patch is broken, as became apparent when I no longer could build Git for Windows' MSYS2 runtime after the gawk update to v5.4.0. The part of the build that is failing is where it generated the `tlsoffsets` file. In particular, with `LC_ALL=C` the following invocation: printf 'void (*func) (int, siginfo_t *, void *);\n' | gawk ' { # Filter out function names print gensub (/\(\*(\w+)\)\s*\([^\)]*\)/, "\\1", "g"); } ' does not print the expected: void func; but instead: void (*func) (int, siginfo_t *, void *); I did verify that the scripts with umlauts in their filenames can still be executed via double-clicking, even after reverting this here patch. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
d765f7e to
4c22b03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried to deploy Git for Windows' MSYS2 runtime v3.6.7, it failed the CI build with a really unhelpful:
This despite the fact that MSYS2's own MSYS2 runtime v3.6.7 deployed just fine. The reason is that the gawk update to v5.4.0 unveiled an erroneous bug fix that Git for Windows still carries. The part of the build that was failing was where it generated the
tlsoffsetsfile. Over the course of a day, I reduced this to a small reproducer. In particular, withLC_ALL=Cthe following invocation:does not print the expected:
but instead:
I did verify that reverting the bug fix lets the build succeed again, and that it does not regress on git-for-windows/git#2189: scripts with umlauts in their filenames can still be executed via double-clicking even after reverting. So let's do that.
As a very nice bonus, it reduces the divergence between MSYS2's and Git for Windows' variant of the MSYS2 runtime.