Skip to content

Fix maxBackups=0 to fully disable automatic backups #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ewgdg wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Fix maxBackups=0 to fully disable automatic backups #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/IconicPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1435,6 +1435,11 @@ export default class IconicPlugin extends Plugin {
const backupPath = normalizePath(dataPath + '.backup');
const { adapter } = this.app.vault;

// Disable automatic backups when set to "none"
if (this.settings.maxBackups <= 0) {
return;
}

// Determine if a new backup is due for creation
const backupStat = await adapter.stat(backupPath + 1);
const isDueForBackup = !backupStat || Date.now() - backupStat.mtime >= HOUR * 3;
Expand Down