Fix maxBackups=0 to fully disable automatic backups#218
Open
ewgdg wants to merge 1 commit intogfxholo:mainfrom
Open
Fix maxBackups=0 to fully disable automatic backups#218ewgdg wants to merge 1 commit intogfxholo:mainfrom
ewgdg wants to merge 1 commit intogfxholo:mainfrom
Conversation
ewgdg
force-pushed
the
fix-disable-backups-when-zero
branch
from
447f8fe to
ad4c173
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxBackups = 0fully disable automatic backups.0.Problem
0asNone.data.json.backup1could still be created even whenmaxBackupswas set to0.Fix
saveBackup()whenthis.settings.maxBackups <= 0.Result
maxBackups > 0: existing rotation behavior remains unchanged.maxBackups = 0: no automatic backup creation or rotation.Validation
npm run build