Conversation
Contributor
Sentry Snapshot Testing
|
40448de to
9e1f5fe
Compare
evanpurkhiser
approved these changes
Apr 15, 2026
The SCM onboarding flow was using the generic 'onboarding' view value for integrations.installation_complete analytics. Rename to 'onboarding_scm' to avoid ambiguity with other surfaces that may use 'onboarding', ensuring clean experiment data. Refs VDY-81
9e1f5fe to
2296e6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SCM onboarding flow was using the generic and preexisting
view: 'onboarding'value when trackingintegrations.installation_completeanalytics. This is ambiguous since'onboarding'could be reused by other integration surfaces, which would pollute experiment data for the SCM onboarding experiment.Adds a new
'onboarding_scm'view value and uses it inscmProviderPills.tsx. The existing'onboarding'value is preserved for other callers.Refs VDY-81