Skip to content

Commit 40448de

Browse files
committed
ref(onboarding): Rename SCM integration analytics view to onboarding_scm
The SCM onboarding flow was using the generic 'onboarding' view value for integrations.installation_complete analytics. Rename to 'onboarding_scm' to avoid ambiguity with other surfaces that may use 'onboarding', ensuring clean experiment data. Refs VDY-81
1 parent 7e460cf commit 40448de

File tree

4 files changed

+4
-1
lines changed

4 files changed

+4
-1
lines changed

static/app/utils/analytics/integrations/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export type IntegrationView = {
1616
| 'stacktrace_issue_details'
1717
| 'integration_configuration_detail'
1818
| 'onboarding'
19+
| 'onboarding_scm'
1920
| 'project_creation'
2021
| 'developer_settings'
2122
| 'new_integration_modal'

static/app/views/onboarding/components/scmProviderPills.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export function ScmProviderPills({providers, onInstall}: ScmProviderPillsProps)
2121
type: 'first_party',
2222
installStatus: 'Not Installed',
2323
analyticsParams: {
24-
view: 'onboarding',
24+
view: 'onboarding_scm',
2525
already_installed: false,
2626
},
2727
}}

static/app/views/settings/organizationIntegrations/addIntegration.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ export interface AddIntegrationParams {
2323
| 'integrations_directory_integration_detail'
2424
| 'integrations_directory'
2525
| 'onboarding'
26+
| 'onboarding_scm'
2627
| 'project_creation'
2728
| 'seer_onboarding_github'
2829
| 'seer_onboarding_code_review'

static/app/views/settings/organizationIntegrations/integrationContext.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ type IntegrationContextProps = {
1111
| 'integrations_directory_integration_detail'
1212
| 'integrations_directory'
1313
| 'onboarding'
14+
| 'onboarding_scm'
1415
| 'project_creation'
1516
| 'seer_onboarding_github'
1617
| 'seer_onboarding_code_review'

0 commit comments

Comments
 (0)