Skip to content

fix(preprod): Hide approve button on status check when snapshots already approved #112978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicoHinderling merged 1 commit into from
Apr 14, 2026
Merged

fix(preprod): Hide approve button on status check when snapshots already approved #112978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/sentry/preprod/vcs/status_checks/snapshots/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,11 @@ def create_preprod_snapshot_status_check_task(
changes_map,
approvals_map=approvals_map,
)
if any(changes_map.values()):
has_unapproved_changes = any(
has_changes and artifact_id not in approvals_map
for artifact_id, has_changes in changes_map.items()
)
if has_unapproved_changes:
approve_action_identifier = APPROVE_SNAPSHOT_ACTION_IDENTIFIER

completed_at: datetime | None = None
Expand Down
Loading