fix(preprod): Hide approve button on status check when snapshots already approved#112978
Merged
NicoHinderling merged 1 commit intomasterfrom Apr 14, 2026
Merged
Conversation
…ady approved Previously the GitHub check run always showed the Approve button when any snapshot changes existed, even if all changes were already approved. Now the button is only included when there are unapproved changes. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
rbro112
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide the GitHub check run "Approve" button when all snapshot changes
have already been approved.
Previously,
approve_action_identifierwas set wheneverchanges_maphad any truthy entries — regardless of whether those changes were
already approved. This meant the Approve button persisted on the check
run even after a user approved all snapshots (either via the Sentry UI
or the GitHub button itself).
Now the condition cross-references
approvals_mapto only include thebutton when at least one changed artifact remains unapproved. This is
consistent with how
_compute_snapshot_statusalready determinespass/fail status.