Skip to content

fix(np): Updates issue notification data factory to select correct handler class #112892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GabeVillalobos merged 2 commits into from
Apr 14, 2026
+2 −3
Merged

fix(np): Updates issue notification data factory to select correct handler class #112892

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7a43e2
fix(np): Updates issue notification data factory to select correct ha…
GabeVillalobos Apr 14, 2026
c337c86
Removes dead handler None check
GabeVillalobos Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/sentry/notifications/notification_action/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,12 @@


def issue_notification_data_factory(invocation: ActionInvocation) -> IssueNotificationData:
from sentry.notifications.notification_action.types import BaseIssueAlertHandler

action = invocation.action
detector = invocation.detector
event_data = invocation.event_data

rule_instance = BaseIssueAlertHandler.create_rule_instance_from_action(
handler = issue_alert_handler_registry.get(action.type)

Check warning on line 120 in src/sentry/notifications/notification_action/utils.py

View check run for this annotation

@sentry/warden / warden: sentry-backend-bugs

Unhandled NoRegistrationExistsError when looking up issue alert handler 

The `issue_notification_data_factory` function calls `issue_alert_handler_registry.get(action.type)` without catching `NoRegistrationExistsError`. If `action.type` is not registered in the issue alert handler registry, this will raise an unhandled exception and crash. Other functions in this same file (`execute_via_issue_alert_handler` at line 76, `execute_via_metric_alert_handler` at line 98) correctly wrap this same registry lookup in try/except. This inconsistency suggests the error handling was overlooked.
rule_instance = handler.create_rule_instance_from_action(
action=action,
detector=detector,
event_data=event_data,
Expand Down
Loading