Skip to content

fix(prompts-activity): Allow org members to write to prompts-activity#112738

Merged
malwilley merged 2 commits intomasterfrom
malwilley/onboarding-banner-v1
Apr 10, 2026
Merged

fix(prompts-activity): Allow org members to write to prompts-activity#112738
malwilley merged 2 commits intomasterfrom
malwilley/onboarding-banner-v1

Conversation

@malwilley
Copy link
Copy Markdown
Member

@malwilley malwilley commented Apr 10, 2026

This PR back in November fixed a vulnerability in prompts-activity: #103753

However, that change also removed the custom permissions which allowed users to use the PUT method. Attempting to dismiss prompts currently results in a 403 unless you have org write access, since it defaults the OrganizationEndpoint permissions.

The migration to OrganizationEndpoint in #103753 inadvertently tightened
PUT permissions to require org:write. Since prompts are user-scoped UI
state, any org member should be able to dismiss their own banners.

Add PromptsActivityPermission allowing org:read for both GET and PUT,
matching the pattern used by OnboardingTaskPermission.
@malwilley malwilley requested review from a team as code owners April 10, 2026 20:49
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 10, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 80739f4. Configure here.

Comment thread src/sentry/api/endpoints/prompts_activity.py Outdated
@malwilley malwilley merged commit 22abf26 into master Apr 10, 2026
58 checks passed
@malwilley malwilley deleted the malwilley/onboarding-banner-v1 branch April 10, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants