Merged
Conversation
Replace inline link-priority button with a proper xs button for the tour action and an ExternalLink for the docs link. This gives better visual hierarchy and avoids the bold-text issue with priority="link" buttons. Also increases gap between banner text and actions for better spacing.
github-actions
bot
added
the
Scope: Frontend
malwilley
commented
Apr 10, 2026
Member
Author
There was a problem hiding this comment.
I extracted the modal part of this into a separate component so I could use it in both the banner and info button
malwilley
commented
Apr 10, 2026
| > | ||
| <AlertsRedirectNotice> | ||
| {t('Alert Rules have been moved to Monitors and Alerts.')} | ||
| </AlertsRedirectNotice> |
Member
Author
There was a problem hiding this comment.
This old redirect notice is being replaced with the new banner
saponifi3d
approved these changes
Apr 10, 2026
| trackAnalytics('monitors.onboarding_modal_viewed', {organization, step: 0}); | ||
| openModal(deps => <AlertsMonitorsShowcase {...deps} />, { | ||
| modalCss: (theme: Theme) => css` | ||
| width: 490px; |
Contributor
There was a problem hiding this comment.
should we use a variable for this so it works on mobile as well? (not sure if we just do a full width on the showcase for mobile or not -- seems like a reasonable deafult if we wanted it)
Member
Author
There was a problem hiding this comment.
Modals do have a max-width: 100% style so this should work on mobile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ISWF-2160
Figma designs (not perfectly matching - I changed the tour link to a Button, we don't have any design system components that make a button look just like a link, for good reason)
Note that I did find a bug with the prompts-activity endpoint. There is a PR here to fix it: #112738