Skip to content

fix(uptime): fix cron monitor incident timing inconsistency #112692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
klochek wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −4
Open

fix(uptime): fix cron monitor incident timing inconsistency #112692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa5d13f
fix(uptime): two possible fixes for cron monitor incident timing inco…
klochek Apr 10, 2026
3484af5
fix(uptime): fix cron monitor incident timing inconsistency
klochek Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/sentry/monitors/logic/incident_occurrence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import uuid
from collections import Counter
from collections.abc import Mapping, Sequence
from datetime import datetime, timezone
from datetime import datetime
from typing import TYPE_CHECKING

from arroyo import Topic as ArroyoTopic
Expand Down Expand Up @@ -138,8 +138,6 @@ def send_incident_occurrence(
"""
monitor_env = failed_checkin.monitor_environment

current_timestamp = datetime.now(timezone.utc)

# Get last successful check-in to show in evidence display
last_successful_checkin_timestamp = "Never"
last_successful_checkin = monitor_env.get_last_successful_checkin()
Expand Down Expand Up @@ -217,7 +215,7 @@ def send_incident_occurrence(
"monitor.slug": str(monitor_env.monitor.slug),
"monitor.incident": str(incident.id),
},
"timestamp": current_timestamp.isoformat(),
"timestamp": received.isoformat(),
}

if trace_id:
Expand Down
Loading