fix(uptime): fix cron monitor incident timing inconsistency#112692
Open
fix(uptime): fix cron monitor incident timing inconsistency#112692
Conversation
github-actions
bot
added
the
Scope: Backend
Ensure we use the same kind of 'time' for timestamps when computing the start and end of crons open periods. We currently use the consumer processing time for the start of an open period, but use the relay time for the close of it. In the event that a cron start is massively delayed due to backlogging, we wind up with the end coming before the start. This corrects that inconsistency by using the relay time for the open period start.
klochek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure we use the same kind of 'time' for timestamps when computing the start and end of crons open periods.
We currently use the consumer processing time for the start of an open period, but use the relay time for the close of it. In the event that a cron start is massively delayed due to backlogging, we wind up with the end coming before the start. This corrects that inconsistency by using the relay time for the open period start.