fix(explore): increase logs infinite query maxPages when we don't have many rows locally

[JoshuaKGoldberg]

Previously, the maxPages for infinitely querying logs was hardcoded to 30 (MAX_LOGS_INFINITE_QUERY_PAGES). This is good in case there are many big logs to amke sure the local browser doesn't run out of data. But if there are many "blank" pages (gaps) of query results, which can happen when the logs are very sporadic, we end up hitting the maximum page limit for queries and losing some.

This goes for a higher 300 (MAX_LOGS_INFINITE_QUERY_PAGES_EXPANDED) when there are fewer than 500 (LOCAL_LOG_ROWS_FOR_EXPANDED_INFINITE_PAGES) rows locally. We're thinking this should allow more pages so we don't bump into the max storage - while not risking running out of browser memory.

Fixes EXP-865

Made with Cursor

The RCA and solution idea for this came from @k-fish (🥔), so essentially:

Co-authored-by: @k-fish

[linear-code]

EXP-865 Live refresh in Explore logs flickers between data and empty state

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Inverted condition returns wrong maxPages limit
  • Inverted the ternary condition so that fewer rows (<500) returns the higher limit (300) and more rows (≥500) returns the lower limit (30), and corrected the JSDoc comment.

Or push these changes by commenting:

@cursor push 403f4fffa2

Preview (403f4fffa2)

diff --git a/static/app/views/explore/logs/constants.tsx b/static/app/views/explore/logs/constants.tsx
--- a/static/app/views/explore/logs/constants.tsx
+++ b/static/app/views/explore/logs/constants.tsx
@@ -22,7 +22,7 @@
 export const MAX_LOGS_INFINITE_QUERY_PAGES = 30; // This number * the refresh interval must be more seconds than 2 * the smallest time interval in the chart for streaming to work.
 /** Larger page cap once enough rows are cached (see useInfiniteLogsQuery). */
 export const MAX_LOGS_INFINITE_QUERY_PAGES_EXPANDED = 300;
-/** Below this many rows in the client cache, use {@link MAX_LOGS_INFINITE_QUERY_PAGES}. */
+/** Below this many rows in the client cache, use {@link MAX_LOGS_INFINITE_QUERY_PAGES_EXPANDED}. */
 export const LOCAL_LOG_ROWS_FOR_EXPANDED_INFINITE_PAGES = 500;
 
 /**

diff --git a/static/app/views/explore/logs/useLogsQuery.tsx b/static/app/views/explore/logs/useLogsQuery.tsx
--- a/static/app/views/explore/logs/useLogsQuery.tsx
+++ b/static/app/views/explore/logs/useLogsQuery.tsx
@@ -414,8 +414,8 @@
   const rows =
     cached?.pages?.reduce((n, page) => n + (page[0]?.data?.length ?? 0), 0) ?? 0;
   return rows < LOCAL_LOG_ROWS_FOR_EXPANDED_INFINITE_PAGES
-    ? MAX_LOGS_INFINITE_QUERY_PAGES
-    : MAX_LOGS_INFINITE_QUERY_PAGES_EXPANDED;
+    ? MAX_LOGS_INFINITE_QUERY_PAGES_EXPANDED
+    : MAX_LOGS_INFINITE_QUERY_PAGES;
 }
 
 export function useInfiniteLogsQuery({

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit aec7539. Configure here.}