Commit 39f4fa5
fix(explore): increase logs infinite query maxPages when we don't have many rows locally (#112691)
Previously, the `maxPages` for infinitely querying logs was hardcoded to
30 (`MAX_LOGS_INFINITE_QUERY_PAGES`). This is good in case there are
many big logs to amke sure the local browser doesn't run out of data.
But if there are many "blank" pages (gaps) of query results, which can
happen when the logs are very sporadic, we end up hitting the maximum
page limit for queries and losing some.
This goes for a higher 300 (`MAX_LOGS_INFINITE_QUERY_PAGES_EXPANDED`)
when there are fewer than 500
(`LOCAL_LOG_ROWS_FOR_EXPANDED_INFINITE_PAGES`) rows locally. We're
thinking this should allow more pages so we don't bump into the max
storage - while not risking running out of browser memory.
Fixes EXP-865
Made with [Cursor](https://cursor.com)
The RCA and solution idea for this came from @k-fish (🥔), so
essentially:
Co-authored-by: @k-fish
---------
Co-authored-by: Cursor Agent <noreply@cursor.com>1 parent f4b9031 commit 39f4fa5
File tree
2 files changed
+21
-1
lines changed- static/app/views/explore/logs
2 files changed
+21
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
23 | 27 | | |
24 | 28 | | |
25 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
| 32 | + | |
31 | 33 | | |
32 | 34 | | |
| 35 | + | |
33 | 36 | | |
34 | 37 | | |
35 | 38 | | |
| |||
402 | 405 | | |
403 | 406 | | |
404 | 407 | | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
405 | 421 | | |
406 | 422 | | |
407 | 423 | | |
| |||
526 | 542 | | |
527 | 543 | | |
528 | 544 | | |
529 | | - | |
| 545 | + | |
530 | 546 | | |
531 | 547 | | |
532 | 548 | | |
| |||
0 commit comments