Conversation
…iterate on seer config reminder
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
should these query option generators be in their own subdir?
There was a problem hiding this comment.
yeah idk about this yet. i tried making an endpoints/ directory and got discouraged by the ownership rules for it :(
missing patterns here but idk what it should be yet. Ideally we'll have the base *QueryOptions for everything, they could be generated even (only like 19k lines) and then on top of that have onMutate, onError, onSettled callbacks that import the keys, and manage different optimistsic updates and cache-clearing calls.
…nboarding-check cache (#112645) This converts the form to the new form system, does an optimistic update to the cache when a change is made, and clears the cache of `/seer/onboarding-check/` which could change based on if something is enabed/disabled for code-review. The new file, static/app/utils/getSeerOnboardingCheckQueryOptions.tsx, is also added in #112643, but shouldn't conflict as it's the same content.
… on the front. This will also mean that the other callsites are consistent
…SCM and AutofixSetup
|
@billy cut things down a lot, the analytics was really a duplicate of the copywriting logic, so i combined it all together. also i realized that the backend is already checking for valid/supported SCM connections, so the "only supported" check on the frontend wasn't doing anything anymore. I cut out the conditions for beta customers, to simplify things too. We should probably ramp them up with transition & subscription-management messaging at this point if the emails aren't enough |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit db6f58e. Configure here.
2 participants
This updates the conditions for showing the Seer Config Reminder. We're looking at:
all via
/seer/onboarding-check/The conditions for the beta cohort are removed.
I've also updated the styles of the reminder, it was really chunky before for some reason.
Finally, I've added a couple calls to
invalidateQueries()so that/seer/onboarding-check/can be refreshed whenever someone toggle code-review. I need to followup on that in one more spot: on the seer repo details page. I'll also go back and look at SCM providers too, which will be slightly more annoying i think :(