Skip to content

fix(seer): Convert Seer Repo Details form to new form system, clear onboarding-check cache#112645

Merged
ryan953 merged 2 commits intomasterfrom
ryan953/convert-seer-codereview-details-form
Apr 10, 2026
Merged

fix(seer): Convert Seer Repo Details form to new form system, clear onboarding-check cache#112645
ryan953 merged 2 commits intomasterfrom
ryan953/convert-seer-codereview-details-form

Conversation

@ryan953
Copy link
Copy Markdown
Member

@ryan953 ryan953 commented Apr 10, 2026

This converts the form to the new form system, does an optimistic update to the cache when a change is made, and clears the cache of /seer/onboarding-check/ which could change based on if something is enabed/disabled for code-review.

The new file, static/app/utils/getSeerOnboardingCheckQueryOptions.tsx, is also added in #112643, but shouldn't conflict as it's the same content.

@ryan953 ryan953 requested review from a team as code owners April 10, 2026 03:10
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 10, 2026
@ryan953 ryan953 requested review from TkDodo and billyvg April 10, 2026 03:10
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 80f01f1. Configure here.

staleTime,
}
);
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated query options not reused by existing hook

Low Severity

The new getSeerOnboardingCheckQueryOptions function duplicates the SeerOnboardingCheckResponse interface and the apiOptions.as<>()() call already present inline in useSeerOnboardingCheck.tsx. The existing hook was not updated to consume this new shared function, so both files independently define the same response type and query configuration. If the endpoint shape or URL changes, both files need to be updated in lockstep, risking drift.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 80f01f1. Configure here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handled by #112643

@ryan953 ryan953 merged commit 755cff5 into master Apr 10, 2026
65 checks passed
@ryan953 ryan953 deleted the ryan953/convert-seer-codereview-details-form branch April 10, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants