feat(chartcuterie): Support multiple display types in Explore chart rendering#112610
Merged
DominikB2014 merged 1 commit intomasterfrom Apr 9, 2026
Conversation
…endering Refactor Explore chartcuterie rendering to use the plottable infrastructure instead of hardcoded LineSeries, ensuring Slack unfurl charts match the frontend rendering for line, bar, and area charts. Extract createPlottableFromTimeSeries to accept a DisplayType directly, and rename the Widget-dependent variant to createPlottableFromTimeSeriesAndWidget. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
edwardgou-sentry
approved these changes
Apr 9, 2026
DominikB2014
deleted the
dominikbuszowiecki/dain-1481-support-other-display-types-with-explorer
branch
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
…endering (#112610) Refactors the Explore chartcuterie rendering to use the plottable infrastructure (`Line`, `Area`, `Bars` classes and their `toSeries()` methods) instead of hardcoding `LineSeries`. This ensures Slack unfurl charts match the frontend rendering for line, bar, and area display types. `ExploreChartData` now accepts an optional `type` field (`DisplayType`), defaulting to `LINE` for backward compatibility. The Python unfurl code can pass `"type": "bar"` or `"type": "area"` to render different chart types. Also extracts `createPlottableFromTimeSeries(displayType, timeSeries, config?)` as a reusable function that takes a `DisplayType` directly, and renames the `Widget`-dependent variant to `createPlottableFromTimeSeriesAndWidget`. Refs DAIN-1481 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the Explore chartcuterie rendering to use the plottable infrastructure (
Line,Area,Barsclasses and theirtoSeries()methods) instead of hardcodingLineSeries. This ensures Slack unfurl charts match the frontend rendering for line, bar, and area display types.ExploreChartDatanow accepts an optionaltypefield (DisplayType), defaulting toLINEfor backward compatibility. The Python unfurl code can pass"type": "bar"or"type": "area"to render different chart types.Also extracts
createPlottableFromTimeSeries(displayType, timeSeries, config?)as a reusable function that takes aDisplayTypedirectly, and renames theWidget-dependent variant tocreatePlottableFromTimeSeriesAndWidget.Refs DAIN-1481