fix(chartcuterie): Avoid plottable imports that break Node VM sandbox#112668
Merged
DominikB2014 merged 2 commits intomasterfrom Apr 10, 2026
Merged
Conversation
The plottable classes (Line, Area, Bars) import @sentry/react which requires browser globals unavailable in chartcuterie's Node.js VM sandbox. This caused the config eval to fail silently, making chartcuterie fall back to its old config without slack:explore.line. Replace the plottable approach with direct LineSeries/BarSeries/ AreaSeries constructors which are safe for the chartcuterie bundle. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
edwardgou-sentry
approved these changes
Apr 10, 2026
No external consumers after the chartcuterie revert; only used internally by createPlottableFromTimeSeriesAndWidget. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plottable classes (
Line,Area,Bars) import@sentry/reactwhich requires browser globals (window,document, etc.) unavailable in chartcuterie's Node.js VM sandbox. When the config bundle includes these imports,runInNewContextfails during eval, causing chartcuterie to silently fall back to its previous config — which doesn't includeslack:explore.line. This broke all Explore Slack unfurls.Replaces the plottable
toSeries()approach with directLineSeries/BarSeries/AreaSeriesconstructors, which are lightweight wrappers that are safe for the chartcuterie bundle. Keeps theDisplayTypesupport for rendering different chart types.Fixes https://linear.app/getsentry/issue/DAIN-1486/unfurl-fails