fix(slot): Render nothing when no outlet is registered#112568
Merged
JonasBa merged 1 commit intojb/cmdk/jsx-pocfrom Apr 9, 2026
Merged
fix(slot): Render nothing when no outlet is registered#112568JonasBa merged 1 commit intojb/cmdk/jsx-pocfrom
JonasBa merged 1 commit intojb/cmdk/jsx-pocfrom
Conversation
Stop rendering slot consumer content in place when no outlet element is available. This avoids the initial flash at the wrong DOM position and prevents remounts caused by switching from inline rendering to a portal once the outlet appears. Co-Authored-By: OpenAI Codex <noreply@openai.com>
github-actions
bot
added
the
Scope: Frontend
TkDodo
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render slot consumer content only after an outlet element is available.
Previously the slot consumer rendered its children in place until the outlet mounted, then switched over to a portal. That caused a flash of content at the wrong DOM position and changed the rendered element type under React, which reset component identity across outlet lifecycle changes.
This makes the consumer return
nulluntil the outlet is ready and updates the slot tests to match that behavior.Refs GH-112564