Closed
Conversation
github-actions
bot
added
the
Scope: Frontend
Previously, SlotConsumer fell back to rendering children in-place when no outlet element was registered. This caused two problems: a flash of content at the wrong DOM position before the portal teleported it to the outlet, and a React subtree remount (in-place ReactNode vs ReactPortal are different element types) that reset useId() keys on every outlet mount/unmount cycle. Render null instead, so content only appears once the outlet is ready and component identity is preserved across outlet lifecycle changes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
If allInQuerySelected is already true, calling toggleSelectAllVisible() followed by setAllInQuerySelected(true) would deselect everything then immediately re-select it — two unnecessary state updates. Guard the action so it is a no-op when the full query is already selected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Register CMDK actions for the issues feed: select all + bulk actions (resolve, archive, set priority, merge) and individual issue actions for each visible issue in the list. Co-Authored-By: Claude <noreply@anthropic.com>
Move ErrorLevel indicator into the label alongside the title, drop the separate level text from details, shrink title to sm and details to xs, add paddingBottom to the label for breathing room, and use getTextValue when pushing nav-stack entries so rich ReactNode labels produce correct placeholder text. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Apr 9, 2026
Member
Author
JonasBa
added a commit
that referenced
this pull request
Apr 9, 2026
Render slot consumer content only after an outlet element is available. Previously the slot consumer rendered its children in place until the outlet mounted, then switched over to a portal. That caused a flash of content at the wrong DOM position and changed the rendered element type under React, which reset component identity across outlet lifecycle changes. This makes the consumer return `null` until the outlet is ready and updates the slot tests to match that behavior. Refs GH-112564 Co-authored-by: OpenAI Codex <noreply@openai.com>
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by split PRs based on
jb/cmdk/jsx-poc:fix(slot): Render nothing when no outlet is registeredfeat(cmdk): Add issue feed actionsClosing this PR to make review easier and keep the remaining changes focused.