feat(preprod): Add snapshot auto-approval for repeated PR builds#112421
Merged
NicoHinderling merged 9 commits intomasterfrom Apr 8, 2026
Merged
feat(preprod): Add snapshot auto-approval for repeated PR builds#112421NicoHinderling merged 9 commits intomasterfrom
NicoHinderling merged 9 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
…of using empty strings
NicoHinderling
force-pushed
the
snapshots-auto-approval
branch
from
1f01f62 to
4023b4b
Compare
github-actions
bot
added
the
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8a77ec7. Configure here.
…comparison Wrap _try_auto_approve_snapshot in try/except so an unhandled exception doesn't propagate to the outer BaseException handler, which would incorrectly mark an already-successful comparison as FAILED.
rbro112
reviewed
Apr 8, 2026
rbro112
reviewed
Apr 8, 2026
rbro112
approved these changes
Apr 8, 2026
Replace raw tuple[str, ...] with a typed ImageFingerprint NamedTuple for better readability of the name, status, hash, and previous_image_file_name fields in snapshot auto-approval fingerprints. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
…2421) Closes EME-976 Adds auto-approval logic for snapshot comparisons. When a snapshot build on a PR is approved and a subsequent build is uploaded for the same PR (e.g. after a rebase), the new build is automatically approved if its "interesting" images (changed, added, removed, errored, renamed) match the previously approved build — same image names, same categories, and same content hashes. This addresses a pain point where rebasing a PR would pull in new unchanged images from main, causing the snapshot comparison to lose its approval even though the PR's actual visual changes hadn't changed. Users were forced to re-approve identical snapshots after every rebase. The old Emerge implementation required an exact one-to-one match of ALL images between builds, which broke on rebases. The new approach only compares the non-unchanged subset, so new unchanged images from main don't affect auto-approval. Content hashes are still verified to ensure the PR's actual visual output hasn't changed. The matching scopes to the same project, app_id, build_configuration, PR number, and repo name to prevent cross-build false matches. how the UI looks for an auto-approved snapshot <img width="1726" height="1744" alt="CleanShot 2026-04-07 at 15 45 02@2x" src="https://github.com/user-attachments/assets/e9a01fc0-5a0f-47ef-880d-a4c69f963be2" /> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes EME-976
Adds auto-approval logic for snapshot comparisons. When a snapshot build on a PR is approved and a subsequent build is uploaded for the same PR (e.g. after a rebase), the new build is automatically approved if its "interesting" images (changed, added, removed, errored, renamed) match the previously approved build — same image names, same categories, and same content hashes.
This addresses a pain point where rebasing a PR would pull in new unchanged images from main, causing the snapshot comparison to lose its approval even though the PR's actual visual changes hadn't changed. Users were forced to re-approve identical snapshots after every rebase.
The old Emerge implementation required an exact one-to-one match of ALL images between builds, which broke on rebases. The new approach only compares the non-unchanged subset, so new unchanged images from main don't affect auto-approval. Content hashes are still verified to ensure the PR's actual visual output hasn't changed.
The matching scopes to the same project, app_id, build_configuration, PR number, and repo name to prevent cross-build false matches.
how the UI looks for an auto-approved snapshot
