fix(preprod): Skip images with missing hashes in fingerprint instead of using empty strings

Author: NicoHinderling

src/sentry/preprod/snapshots/tasks.py

@@ -119,11 +119,13 @@ def _build_comparison_fingerprints(manifest: ComparisonManifest) -> set[tuple[st
         if image.status == "unchanged":
             continue
         if image.status in ("changed", "added"):
-            fingerprints.add((name, image.status, image.head_hash or ""))
+            if not image.head_hash:
+                continue
+            fingerprints.add((name, image.status, image.head_hash))
         elif image.status == "renamed":
-            fingerprints.add(
-                (name, "renamed", image.head_hash or "", image.previous_image_file_name or "")
-            )
+            if not image.head_hash or not image.previous_image_file_name:
+                continue
+            fingerprints.add((name, "renamed", image.head_hash, image.previous_image_file_name))
         else:
             fingerprints.add((name, image.status))
     return fingerprints

tests/sentry/preprod/snapshots/test_auto_approve.py

@@ -136,6 +136,33 @@ def test_empty_manifest_returns_empty_set(self):
         fps = _build_comparison_fingerprints(manifest)
         assert fps == set()
 
+    def test_skips_changed_with_missing_head_hash(self):
+        manifest = self._make_manifest(
+            {
+                "no_hash.png": ComparisonImageResult(status="changed", base_hash="abc"),
+                "has_hash.png": ComparisonImageResult(
+                    status="changed", head_hash="def", base_hash="ghi"
+                ),
+            }
+        )
+        fps = _build_comparison_fingerprints(manifest)
+        assert fps == {("has_hash.png", "changed", "def")}
+
+    def test_skips_renamed_with_missing_hash_or_previous_name(self):
+        manifest = self._make_manifest(
+            {
+                "no_hash.png": ComparisonImageResult(
+                    status="renamed", previous_image_file_name="old.png"
+                ),
+                "no_prev.png": ComparisonImageResult(status="renamed", head_hash="abc"),
+                "valid.png": ComparisonImageResult(
+                    status="renamed", head_hash="def", previous_image_file_name="old_valid.png"
+                ),
+            }
+        )
+        fps = _build_comparison_fingerprints(manifest)
+        assert fps == {("valid.png", "renamed", "def", "old_valid.png")}
+
 
 def _mock_session_with_manifests(manifests_by_key: dict[str, bytes]) -> MagicMock:
     session = MagicMock()