Conversation
…didates Switch get_profile_candidates_from_profiles to query the Spans EAP dataset via get_spans_based_candidates instead of building a DiscoverQueryBuilder against Dataset.Discover. Adds is_transaction:true to the query to preserve equivalence with the previous transactions dataset behavior. This removes the exponential chunking loop which was a workaround for querying the transactions dataset efficiently. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
wmak
approved these changes
Apr 9, 2026
Member
wmak
left a comment
wmak
left a comment
There was a problem hiding this comment.
LGTM, but as mentioned in slack would like to see verification that we can run this query without chunking before we merge this 👍
mjq
deleted the
mjq/remove-transactions-dependency-from-flamegraph-endpoint-profiles-data-source
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling the flamegraph endpoint with
data_sourceset toprofilesstill hits the transactions dataset when searching for matching profiles. Switch to query the Spans EAP dataset via the existingget_spans_based_candidatesinstead. (By addingis_transaction:trueto the spans query, you'll get equivalent results as the previous transactions query).This also removes the exponential chunking loop which was a workaround for querying the transactions dataset efficiently - with EAP we should be able to just make the query in one go (as we already do when
data_sourceisspans).Fixes DAIN-1463.