feat(eslint): enable @typescript-eslint/no-unnecessary-type-parameters by JoshuaKGoldberg · Pull Request #112404 · getsentry/sentry

JoshuaKGoldberg · 2026-04-07T20:34:37Z

Enables @typescript-eslint/no-unnecessary-type-parameters internally. This enforces the "Golden Rule of Generics":

Rule: If a type parameter only appears in one location, strongly reconsider if you actually need it.

Summarizing the rule's docs (would recommend reading, especially the FAQs) and that excellent blog post (definitely would recommend the read!): if a type parameter (commonly: <T>) is only used in one place, it's not actually useful. Single-use type parameters almost always either do nothing or mask an unsafe type assertion.

I added explainer comments inline in the PR.

Fixes ENG-7007

linear-code · 2026-04-07T20:36:22Z

ENG-7007 Enable @typescript-eslint/no-duplicate-type-constituents

JoshuaKGoldberg · 2026-04-07T20:37:22Z

 }

-export function getEscapedKey<Value extends SelectKey | undefined>(value: Value): string {
+export function getEscapedKey(value: SelectKey): string {


[Explanation] This is an example of a type parameter that did nothing. Value didn't change the function's return type at all. So value's type effectively already was SelectKey.

JoshuaKGoldberg · 2026-04-07T20:38:03Z

-export function useOrganizationRepositories<T extends Repository = Repository>(
-  {query = {}} = {} as Props
-) {
+export function useOrganizationRepositories({query = {}} = {} as Props) {


[Explanation] This, too, is an example of a type parameter doing nothing. T shows up later in the function, but those uses don't impact the return type. https://typescript-eslint.io/rules/no-unnecessary-type-parameters/#im-using-the-type-parameter-inside-the-function-so-why-is-the-rule-reporting

JoshuaKGoldberg · 2026-04-07T20:39:02Z


 type KnownDataDetails = Omit<KeyValueListDataItem, 'key'> | undefined;

+// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-parameters


[Explanation] This is used in a few places and seems to be a kind of intentional "just give me the value as a specific type". I tried for a couple minutes to fix it locally but it was nontrivial.

JoshuaKGoldberg · 2026-04-07T20:41:23Z

      threshold: 0.6,
      location: 0,
      distance: 100,
-      maxPatternLength: 32,


[Explanation] This is, I believe, legitimately dead code now detected by TypeScript!

Before, createFuzzySearch in fuzzySearch.tsx had a type parameter for its options. That meant any arbitrary property like maxPatternLength would be allowed and counted as part of the type argument.

Now that options is only ever Fuse.IFuseOptions<T>, unknown property names are not allowed. maxPatternLength was removed in Fuse v5. https://github.com/krisk/Fuse/blob/main/CHANGELOG.md#version-500-beta

JoshuaKGoldberg · 2026-04-07T20:42:15Z


 /**
- * Identity function that casts the raw completion data to a typed shape.
+ * Identity function that asserts the raw completion data to a typed shape.


[Explanation] This is super nitpicky, please forgive me: but assertions and casts are not the same. This function asserts (type system only, unsafe). It doesn't cast (runtime change, safe in this context).

good call out

JoshuaKGoldberg · 2026-04-07T20:46:33Z

-  return function WithDomainRedirectWrapper(props: P) {
+export function withDomainRedirect(WrappedComponent: RouteComponent) {
+  // eslint-disable-next-line @typescript-eslint/no-restricted-types
+  return function WithDomainRedirectWrapper(props: object) {


[Explanation] Our ESLint config includes an option for @typescript-eslint/no-restricted-types copied from the old defaults for @typescript-eslint/ban-types:

sentry/eslint.config.ts

Lines 657 to 661 in 2795da8

object: {

message:

'The `object` type is hard to use. Use `Record<PropertyKey, unknown>` instead. See: https://github.com/typescript-eslint/typescript-eslint/pull/848',

fixWith: 'Record<PropertyKey, unknown>',

},

See https://typescript-eslint.io/blog/revamping-the-ban-types-rule: that old value is no longer the recommendation. Mucking with that is out of scope for this PR, I think.

JoshuaKGoldberg · 2026-04-07T20:52:55Z

+  ): ChildType | null;
+  findChild(predicate: (child: BaseNode) => boolean): BaseNode | null;
+  findChild<ChildType extends BaseNode = BaseNode>(
+    predicate: (child: BaseNode) => child is ChildType


[Explanation] These methods are used in roughly two types situations, corresponding to the two function overloads in order:

Oftentimes they're given a true type predicate. This gives us a nicely narrowed return type, so we put it first as the preferred form.

As a fallback, if the function just returns boolean (no type system indication as to what type the value is), we just return the same broad type as the value.

Aside: I haven't had a good excuse to write function overloads with generics in a while. It was nice to actually have a use for that knowledge, for once. 🥲

P.S. https://effectivetypescript.com/2024/02/27/type-guards is a great article on type predicates.

TkDodo · 2026-04-08T13:50:35Z

+// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-parameters
 export function getApiQueryData<TResponseData>(


love this! It surfaces type parameters that are type assertions in disguise ❤️

@TkDodo

Co-authored-by: @TkDodo

… static/gsApp/utils/trackSpendVisibilityAnalytics.tsx

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 8422c6d. Configure here.}

#112404) Enables [`@typescript-eslint/no-unnecessary-type-parameters`](https://typescript-eslint.io/rules/no-unnecessary-type-parameters) internally. This enforces the ["Golden Rule of Generics"](https://effectivetypescript.com/2020/08/12/generics-golden-rule): > **Rule: If a type parameter only appears in one location, strongly reconsider if you actually need it.** Summarizing the rule's docs (would recommend reading, especially the FAQs) and that excellent blog post (definitely would recommend the read!): if a type parameter (commonly: `<T>`) is only used in one place, it's not actually useful. Single-use type parameters almost always either do nothing or mask an unsafe type assertion. I added explainer comments inline in the PR. Fixes ENG-7007

JoshuaKGoldberg · 2026-04-10T12:26:26Z

Fixes ENG-7256.

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 7, 2026

JoshuaKGoldberg commented Apr 7, 2026

View reviewed changes

Comment thread static/app/components/searchSyntax/parser.tsx Outdated

JoshuaKGoldberg commented Apr 7, 2026

View reviewed changes

JoshuaKGoldberg force-pushed the tseslint-no-unnecessary-type-parameters branch from 2795da8 to 0fb330c Compare April 7, 2026 20:53

JoshuaKGoldberg mentioned this pull request Apr 7, 2026

fix(logs): adjust back-to-top containers to window width resize #112374

Merged

vercel bot deployed to Preview April 7, 2026 20:54 View deployment

feat(eslint): enable @typescript-eslint/no-unnecessary-type-parameters

d590db9

JoshuaKGoldberg force-pushed the tseslint-no-unnecessary-type-parameters branch from 0fb330c to d590db9 Compare April 7, 2026 21:02

vercel bot deployed to Preview April 7, 2026 21:03 View deployment

JoshuaKGoldberg marked this pull request as ready for review April 7, 2026 21:10

JoshuaKGoldberg requested review from a team as code owners April 7, 2026 21:10

JoshuaKGoldberg removed request for a team April 7, 2026 21:10

cursor bot reviewed Apr 7, 2026

View reviewed changes

Comment thread static/gsApp/views/subscriptionPage/pendingChanges.tsx

Comment thread static/app/utils/analytics/makeAnalyticsFunction.tsx Outdated

Cursor touchups

ff955b8

vercel bot deployed to Preview April 8, 2026 13:26 View deployment

TkDodo reviewed Apr 8, 2026

View reviewed changes

TkDodo approved these changes Apr 8, 2026

View reviewed changes

ref: more cleanly use ...args for tryParseSearch

52665dc

Co-authored-by: @TkDodo

vercel bot deployed to Preview April 8, 2026 14:02 View deployment

cursor bot reviewed Apr 8, 2026

View reviewed changes

Comment thread static/gsApp/views/subscriptionPage/pendingChanges.tsx

Comment thread static/gsApp/utils/trackGetsentryAnalytics.tsx Outdated

git checkout master -- static/gsApp/utils/trackGetsentryAnalytics.tsx…

8422c6d

… static/gsApp/utils/trackSpendVisibilityAnalytics.tsx

vercel bot deployed to Preview April 8, 2026 14:19 View deployment

cursor bot reviewed Apr 8, 2026

View reviewed changes

Comment thread static/app/utils/useLocalStorageState.ts Outdated

fine, use unknown for tryParseStorage

1952e66

vercel bot deployed to Preview April 8, 2026 18:38 View deployment

JoshuaKGoldberg merged commit abe7c05 into master Apr 9, 2026
62 checks passed

JoshuaKGoldberg deleted the tseslint-no-unnecessary-type-parameters branch April 9, 2026 11:58

sentry-release-bot bot mentioned this pull request Apr 15, 2026

publish: getsentry/sentry@26.4.0 getsentry/publish#7817

Closed

3 tasks


		type KnownDataDetails = Omit<KeyValueListDataItem, 'key'> \| undefined;

		// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-parameters

	object: {
	message:
	'The `object` type is hard to use. Use `Record<PropertyKey, unknown>` instead. See: https://github.com/typescript-eslint/typescript-eslint/pull/848',
	fixWith: 'Record<PropertyKey, unknown>',
	},

		// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-parameters
		export function getApiQueryData<TResponseData>(

Uh oh!

Conversation

JoshuaKGoldberg commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-code bot commented Apr 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JoshuaKGoldberg commented Apr 7, 2026 •

edited

Loading

JoshuaKGoldberg Apr 7, 2026 •

edited

Loading